multi-asic support for test_cacl_application.py#3070
Merged
abdosi merged 5 commits intosonic-net:masterfrom Mar 2, 2021
Merged
multi-asic support for test_cacl_application.py#3070abdosi merged 5 commits intosonic-net:masterfrom
abdosi merged 5 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
This pull request introduces 2 alerts when merging ed356c1 into bec8443 - view on LGTM.com new alerts:
|
Contributor
|
Is there a way to fix the LGTM alerts? Yes, Fixed. |
jleveque
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why I did:
test_cacl_application.pyfor multi-asic platforms. Also it adds new test case to cover all multi-asic specific changesas done in PR's:-
sonic-net/sonic-buildimage#5022
sonic-net/sonic-buildimage#5420
sonic-net/sonic-buildimage#5364
sonic-net/sonic-buildimage#6765
How I did:-
Added new test case for multi-asic platforms to run on all front-asic's.
How I verify:
Verified both on single and multi-asic platfroms.