[pdu manager] introduce pdu manager#3013
Merged
yxieca merged 4 commits intosonic-net:masterfrom Feb 22, 2021
Merged
Conversation
1. Introduce PDU manager to separte the client from the implentation of pdu controllers. 2. Change client to toggle outlet with the whole outlet dictionary, so that client don't have to rely on the value of outlet_id. 3. PDU manager manages all PDU controllers associated with a DUT. 4. Change devutils to use PDU manager instead of invoking controller directly. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This comment has been minimized.
This comment has been minimized.
jleveque
suggested changes
Feb 21, 2021
jleveque
suggested changes
Feb 21, 2021
Collaborator
Author
|
You have one warning from LGTM. otherwise looks good. |
jleveque
approved these changes
Feb 22, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#17018) #### Why I did it src/sonic-utilities ``` * 569beb19 - (HEAD -> 202305, origin/202305) Revert "Remove syslog service validator in GCU (sonic-net#2991)" (sonic-net#3015) (16 hours ago) [jingwenxie] * ab7f03ea - [db_migrator] Fix the broken version chain (sonic-net#3014) (16 hours ago) [Vivek] * 0f17b8d5 - [fwutil] Fix python SyntaxWarning for 'is' with literals (sonic-net#3013) (16 hours ago) [Kebo Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Introducing pdu manager.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
The existing PDU controller implementation cannot handle if DUT connects to 2 different PDUs. The outlet_id was an index in return list, when there is more than one controller, the index will collide. Existing client code uses the outlet_id to access specific outlet. Which will not work in multi-PDU scenario.
How did you do it?
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?