[nat] skip nat test when image doesn't have nat feature enabled#2990
Merged
yxieca merged 2 commits intosonic-net:masterfrom Feb 17, 2021
Merged
[nat] skip nat test when image doesn't have nat feature enabled#2990yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
neethajohn
reviewed
Feb 17, 2021
neethajohn
approved these changes
Feb 17, 2021
|
Hello @yxieca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
skip nat test when image doesn't have nat feature enabled
Type of change
Approach
What is the motivation for this PR?
nat tests are failing when executed against image doesn't have feature enabled.
How did you do it?
check feature table and skip the test when feature not enabled.
How did you verify/test it?
run nat test against an image that doesn't have nat feature enabled.