Skip to content

[Platform API][Thermal]: Include 0 in range of valid low threshold, temperature values #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jleveque merged 1 commit into from
Feb 17, 2021
Merged

[Platform API][Thermal]: Include 0 in range of valid low threshold, temperature values #2989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/platform_tests/api/test_thermal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def test_get_temperature(self, duthost, localhost, platform_api_conn):

if self.expect(temperature is not None, "Unable to retrieve Thermal {} temperature".format(i)):
if self.expect(isinstance(temperature, float), "Thermal {} temperature appears incorrect".format(i)):
self.expect(temperature > 0 and temperature <= 100,
self.expect(temperature >= 0 and temperature <= 100,
"Thermal {} temperature {} reading is not within range".format(i, temperature))
self.assert_expectations()

Expand All @@ -153,7 +153,7 @@ def test_get_low_threshold(self, duthost, localhost, platform_api_conn):

if self.expect(low_threshold is not None, "Unable to retrieve Thermal {} low threshold".format(i)):
if self.expect(isinstance(low_threshold, float), "Thermal {} low threshold appears incorrect".format(i)):
self.expect(low_threshold > 0 and low_threshold <= 100,
self.expect(low_threshold >= 0 and low_threshold <= 100,
"Thermal {} low threshold {} reading is not within range".format(i, low_threshold))
self.assert_expectations()

Expand All @@ -175,7 +175,7 @@ def test_get_low_critical_threshold(self, duthost, localhost, platform_api_conn)

if self.expect(low_critical_threshold is not None, "Unable to retrieve Thermal {} low critical threshold".format(i)):
if self.expect(isinstance(low_critical_threshold, float), "Thermal {} low threshold appears incorrect".format(i)):
self.expect(low_critical_threshold > 0 and low_critical_threshold <= 110,
self.expect(low_critical_threshold >= 0 and low_critical_threshold <= 110,
"Thermal {} low critical threshold {} reading is not within range".format(i, low_critical_threshold))
self.assert_expectations()

Expand Down