Added bgpmon verification for test_bgp_allowlist#2977
Merged
abdosi merged 15 commits intosonic-net:masterfrom Feb 22, 2021
Merged
Added bgpmon verification for test_bgp_allowlist#2977abdosi merged 15 commits intosonic-net:masterfrom
abdosi merged 15 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
changed the title
|
This pull request introduces 4 alerts when merging 681d2af into 2a11c0f - view on LGTM.com new alerts:
|
Signed-off-by: Abhishek Dosi <[email protected]>
Contributor
Author
|
@bingwang-ms and @wangxin can you please review this. |
neethajohn
approved these changes
Feb 22, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
ef2a0cd0 [201911] [multi_asic] Script to monitor errors on internal links (sonic-net#2971) 1252e31b Changes to separate UT data for internal link monitor (sonic-net#2976) 3e6654e [[201911] [multi-asic] Unit test fix for internal link monitoring (sonic-net#2977)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Added BGPMON verification for allow list test case. This was done to make so sure BGPMON (since it is iBGP Peer) receive all the routes irrespective if allow list action being permit or deny
Also to support above made bgpmon session creation and route verification as common fixture and helper routines.
How I verify: