[test_show_bgp_summary] Change prefixReceivedCount key due to Frr Update#2927
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 16, 2021
Merged
Conversation
Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
|
retest vsimage please |
Contributor
Author
Collaborator
|
@SavchukRomanLv thanks for address the issue. I noticed that 201911 branch is still not upgraded to FRR 7.5 yet. Do you think you can make the test work for both 201911 and master? |
Contributor
Author
|
@yxieca Test should work for both master and 201911, below is the output of |
yxieca
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii-Yosafat Lozovyi andrii-yosafatx.lozovyi@intel.com
Description of PR
Summary: On master Sonic test_show_bgp_summary fails with error
KeyError: 'prefixReceivedCount. This happens due to recent update of FRR up to version 7.5, after which keyprefixReceivedCounthave changed topfxRcd. So in order to make test pass on Sonic master key should be changed topfxRcd. This wont affect released Sonic version, because it contains both keys.Type of change
Approach
What is the motivation for this PR?
Make test_show_bgp_summary backward compatible.
How did you do it?
Changed the prefixReceivedCount key.
How did you verify/test it?
Run test_show_bgp_summary on t0 topo
vrf/test_vrf.py::TestVrfFib::test_show_bgp_summary PASSEDAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation