Skip to content

[everflow]: Uncomment test and set session TTL to 1 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stcheng merged 1 commit into from
Oct 3, 2017
Merged

[everflow]: Uncomment test and set session TTL to 1 #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ansible/roles/test/tasks/everflow_testbed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
include: "roles/test/tasks/everflow_testbed/apply_config.yml"
tags: everflow_tb_configure

# TODO: Fix issue #288
# Please check URL: https://github.com/Azure/sonic-mgmt/issues/288 to get the detail of the issue
#- name: Run Everflow tests.
# include: "roles/test/tasks/everflow_testbed/run_test.yml"
# vars:
# dst_port_type: "tor"
# tags: everflow_tb_test
- name: Run Everflow tests.
include: "roles/test/tasks/everflow_testbed/run_test.yml"
vars:
dst_port_type: "tor"
tags: everflow_tb_test

- name: Run Everflow tests.
include: "roles/test/tasks/everflow_testbed/run_test.yml"
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/test/tasks/everflow_testbed/apply_config/session.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"dst_ip": "2.2.2.2",
"gre_type": "0x6558",
"dscp": "50",
"ttl": "64",
"ttl": "1",
Copy link
Contributor

@lguohan lguohan Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment on this, why change to ttl=1?

Copy link
Contributor Author

@stcheng stcheng Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit tricky to add comments in the JSON file. I've added enough information in the commit message. git blame is able to find out why this change is here.

"queue": "0"
},
"OP": "SET"
Expand Down