Adjust log analyzer ignore pattern to support both python2 and python3#2830
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jan 19, 2021
Merged
Conversation
3 tasks
wangxin
approved these changes
Jan 19, 2021
liat-grozovik
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
When cast None type to int type, python3 and python2 show different error. In python2, it shows:
While in python3 it shows:
As thermalctd in master branch has been migrated to python3, and 201911 branch is still using python2, we need handle both cases when ignoring such error in log analyzer.
Type of change
Approach
What is the motivation for this PR?
Adjust log analyze ignore pattern to make it work with both python2 and python3
How did you do it?
Change the existing ignore pattern
How did you verify/test it?
Manual test
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation