Skip to content

Adjust log analyzer ignore pattern to support both python2 and python3#2830

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
Junchao-Mellanox:ignore-for-python3
Jan 19, 2021
Merged

Adjust log analyzer ignore pattern to support both python2 and python3#2830
liat-grozovik merged 1 commit intosonic-net:masterfrom
Junchao-Mellanox:ignore-for-python3

Conversation

@Junchao-Mellanox
Copy link
Contributor

Description of PR

Summary:
When cast None type to int type, python3 and python2 show different error. In python2, it shows:

int() argument must be a string or a number, not 'NoneType'

While in python3 it shows:

int() argument must be a string, a bytes-like object or a number, not 'NoneType'

As thermalctd in master branch has been migrated to python3, and 201911 branch is still using python2, we need handle both cases when ignoring such error in log analyzer.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Adjust log analyze ignore pattern to make it work with both python2 and python3

How did you do it?

Change the existing ignore pattern

How did you verify/test it?

Manual test

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

@liat-grozovik liat-grozovik merged commit 45c1738 into sonic-net:master Jan 19, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the ignore-for-python3 branch February 4, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants