[minigraph]: Generate servers for dualtor minigraphs#2792
Merged
theasianpianist merged 2 commits intosonic-net:masterfrom Jan 14, 2021
Merged
[minigraph]: Generate servers for dualtor minigraphs#2792theasianpianist merged 2 commits intosonic-net:masterfrom
theasianpianist merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
requested review from
lguohan,
prsunny,
tahmed-dev,
wangxin and
yxieca
tahmed-dev
approved these changes
Jan 12, 2021
prsunny
reviewed
Jan 12, 2021
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Jan 13, 2021
3 tasks
yxieca
pushed a commit
that referenced
this pull request
Jan 19, 2021
Approach What is the motivation for this PR? PR #2792 introduced neighbor with type 'Server' into 'DEVICE_NEIGHBOR_METADATA' of config DB. The 'Server' neighbors should be skipped in neighbor health check. How did you do it? Skip checking neighbor with type 'Server'. How did you verify/test it? Test run the test_nbr_health.py script on dualtor. Test passed. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#14752) src/sonic-utilities * ece22b7d - (HEAD -> 202205, origin/202205) Revert "[GCU] Add PFC_WD RDMA validator (sonic-net#2781)" (4 minutes ago) [Ying Xie] * 7d16b184 - Remove the no use new line in show version (sonic-net#2792) (21 hours ago) [xumia] * 3a880a2b - Support to display the SONiC OS Version in the command show version (sonic-net#2787) (21 hours ago) [xumia] * a5199f75 - [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards (sonic-net#2606) (21 hours ago) [saksarav-nokia] * 2410d364 - Fixed a bug in "show vnet routes all" causing screen overrun. (sonic-net#2644) (sonic-net#2801) (
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Current minigraph generation does not include servers in the PNG section, which is needed for dual ToR operation.
How did you do it?
For each smart cable generated, also generate one server with a loopback in the same subnet as the DUT VLAN.
Example:
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation