[conn_graph] Fix the fanout connection parsing error#2780
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Jan 8, 2021
Merged
[conn_graph] Fix the fanout connection parsing error#2780bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <[email protected]>
lolyu
reviewed
Jan 8, 2021
bingwang-ms
reviewed
Jan 8, 2021
Signed-off-by: Neetha John <[email protected]>
bingwang-ms
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fanout graph parsing was broken due to #2517
Following errors were seen while running pfcwd tests
E RunAnsibleModuleFail: run module conn_graph_facts failed, Ansible Results =>
E {
E "changed": false,
E "failed": true,
E "invocation": {
E "module_args": {
E "anchor": null,
E "filename": "/var/nejo/Networking-acs-sonic-mgmt/tests/common/fixtures/../../../ansible/files/starlab_connection_graph.xml",
E "filepath": null,
E "host": "str-7260cx3-acs-fan-05",
E "hosts": null
E }
E },
E "msg": "Did not find port for Ethernet23/1 in the ports based on hwsku 'Arista-7260CX3' for host str-7260cx3-acs-fan-05"
E }
Summary:
Fixes # (issue)
Type of change
How did you do it?
Parsing logic added in #2517 was for SONIC duts. Retained the old logic when dev type is FanoutLeaf
How did you verify/test it?
Ran one of the pfcwd tests and it passed