[conn_graph_facts] Enforce uniform return variable data type#2748
Merged
lolyu merged 1 commit intosonic-net:masterfrom Jan 12, 2021
Merged
[conn_graph_facts] Enforce uniform return variable data type#2748lolyu merged 1 commit intosonic-net:masterfrom
lolyu merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
Retest this please |
lolyu
force-pushed
the
refact_conn_graph_facts
branch
from
ff8c8a5 to
2b0f99e
Compare
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
refact_conn_graph_facts
branch
from
2b0f99e to
92c2e32
Compare
yxieca
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Make all the returns from
conn_graph_factsof typedict.Signed-off-by: Longxiang Lyu [email protected]
Type of change
Approach
What is the motivation for this PR?
Enforce uniform returns for
conn_graph_factsfor both single and multi-DUTs.How did you do it?
Make them all dictionary.
How did you verify/test it?
Run add_topo/remove_topo.
Run Pytest.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation