Skip to content

[crm]: Fixed topology check and interface selection for test_crm_fdb_entry #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingwang-ms merged 2 commits into from
Dec 23, 2020
Merged

[crm]: Fixed topology check and interface selection for test_crm_fdb_entry #2655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd31d8
Fix for CRM test_crm_fdb_entry
monipko Dec 11, 2020
bc0e379
Updated test_crm_fdb_entry according PR comments
monipko Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/crm/test_crm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,11 +807,16 @@ def test_acl_counter(duthosts, rand_one_dut_hostname, collector):

def test_crm_fdb_entry(duthosts, rand_one_dut_hostname, tbinfo):
duthost = duthosts[rand_one_dut_hostname]
if "t0" not in tbinfo["topo"]["name"].lower():
pytest.skip("Unsupported topology, expected to run only on 'T0*' topology")

# Test is applicable only for topologies which contain disabled host interface ports
topology = tbinfo["topo"]["properties"]["topology"]
if "disabled_host_interfaces" not in topology:
pytest.skip("Unsupported topology, test requires disabled ports for dummy VLAN interface")
get_fdb_stats = "redis-cli --raw -n 2 HMGET CRM:STATS crm_stats_fdb_entry_used crm_stats_fdb_entry_available"
iface = "Ethernet0"
cfg_facts = duthost.config_facts(host=duthost.hostname, source="persistent")['ansible_facts']
port_dict = dict(zip(cfg_facts['port_index_map'].values(), cfg_facts['port_index_map'].keys()))
# Use for test disabled in topo host port to create dummy VLAN interface
disabled_port_id = [id for id in topology["disabled_host_interfaces"]][0]
iface = port_dict[disabled_port_id]
vlan_id = 2
cmd_add_vlan_member = "config vlan member add {vid} {iface}"
cmd_add_vlan = "config vlan add {}".format(vlan_id)
Expand Down