Skip to content

[drop counters] Add sleep after MTU configuration to avoid test case fail #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daall merged 2 commits into from
Dec 11, 2020
Merged

[drop counters] Add sleep after MTU configuration to avoid test case fail #2641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18936b
[drop counters] Add sleep after MTU configuration to avoid test case …
antoninamelnyk Dec 9, 2020
3b261ce
Use wait_until method to check if MTU has been updated
antoninamelnyk Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/drop_packets/test_drop_counters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ptf.packet as packet
import ptf.testutils as testutils

from tests.common.helpers.assertions import pytest_assert
from tests.common.utilities import wait_until
from drop_packets import * # FIXME

Expand Down Expand Up @@ -217,6 +218,10 @@ def base_verification(discard_group, pkt, ptfadapter, duthost, ports_info, tx_du
pytest.fail("Incorrect 'discard_group' specified. Supported values: 'L2' or 'L3'")


def get_intf_mtu(duthost, intf):
return int(duthost.shell("/sbin/ifconfig {} | grep -i mtu | awk '{{print $NF}}'".format(intf))["stdout"])


@pytest.fixture
def mtu_config(duthosts, rand_one_dut_hostname):
""" Fixture which prepare port MTU configuration for 'test_ip_pkt_with_exceeded_mtu' test case """
Expand All @@ -238,6 +243,8 @@ def set_mtu(cls, mtu, iface):
else:
raise Exception("Unsupported interface parameter - {}".format(iface))
cls.iface = iface
check_mtu = lambda: get_intf_mtu(duthost, iface) == mtu
pytest_assert(wait_until(5, 1, check_mtu), "MTU on interface {} not updated".format(iface))

@classmethod
def restore_mtu(cls):
Expand Down