Skip to content

[syslog] Fixes syslog test case to add a route to PTF server #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shlomibitton wants to merge 2 commits into from
Closed

[syslog] Fixes syslog test case to add a route to PTF server #2573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6686374
Fix syslog test
Nov 22, 2020
882935c
Fix typo
shlomibitton Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion tests/syslog/test_syslog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import pytest
import json

from tests.common.helpers.assertions import pytest_assert
from tests.common.utilities import wait_until
Expand Down Expand Up @@ -42,9 +43,25 @@ def config_dut(tbinfo, duthosts, rand_one_dut_hostname):
duthost = duthosts[rand_one_dut_hostname]
logger.info("Configuring the DUT")
local_syslog_srv_ip = tbinfo["ptf_ip"]
logger.info("test_syslog_srv_ip %s", local_syslog_srv_ip)

# Add static route to PTF docker for rsyslog to work
logger.info("Adding static route to PTF")
config_file_object = duthost.shell("cat /etc/sonic/config_db.json")
if config_file_object["rc"]:
assert("Failed to open config file on '/etc/sonic/config_db.json'")
config_file_content = config_file_object["stdout"]
mgmt_interface_data = json.loads(config_file_content)["MGMT_INTERFACE"]
for key, value in mgmt_interface_data.iteritems():
if key.count('.') == 3:
gw = value["gwaddr"]
break
if not gw:
assert("No IPv4 default GW found for eth0")
duthost.shell("sudo ip route add {}/32 via {} dev eth0".format(local_syslog_srv_ip, gw))
logger.debug("Added new route to PTF with command: sudo ip route add {}/32 via {} dev eth0".format(local_syslog_srv_ip, gw))

# Add Rsyslog destination for testing
logger.info("test_syslog_srv_ip %s", local_syslog_srv_ip)
duthost.shell("sudo config syslog add {}".format(local_syslog_srv_ip))
logger.debug("Added new rsyslog server IP {}".format(local_syslog_srv_ip))

Expand All @@ -53,6 +70,8 @@ def config_dut(tbinfo, duthosts, rand_one_dut_hostname):
# Remove the syslog configuration
duthost.shell("sudo config syslog del {}".format(local_syslog_srv_ip))

# Remove static route to PTF docker
duthost.shell("sudo ip route del {}/32 via {} dev eth0".format(local_syslog_srv_ip, gw))

def test_syslog(duthosts, rand_one_dut_hostname, ptfhost, config_dut):
duthost = duthosts[rand_one_dut_hostname]
Expand Down