Skip to content

[test_nbr_health] ignore SmartCable and/or peer neighbor #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 1 commit into from
Nov 16, 2020
Merged

[test_nbr_health] ignore SmartCable and/or peer neighbor #2536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_nbr_health.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,19 @@ def test_neighbors_health(duthosts, localhost, nbrhosts, eos, enum_dut_hostname)
duthost = duthosts[enum_dut_hostname]
config_facts = duthost.config_facts(host=duthost.hostname, source="running")['ansible_facts']
nei_meta = config_facts.get('DEVICE_NEIGHBOR_METADATA', {})

dut_type = None
dev_meta = config_facts.get('DEVICE_METADATA', {})
if "localhost" in dev_meta and "type" in dev_meta["localhost"]:
dut_type = dev_meta["localhost"]["type"]

for k, v in nei_meta.items():
if 'SmartCable' == v['type'] or dut_type == v['type']:
# Smart cable doesn't respond to snmp, it doesn't have BGP session either.
# DualToR has the peer ToR listed in device as well. If the device type
# is the same as testing DUT, then it is the peer.
continue

failmsg = check_snmp(k, v['mgmt_addr'], localhost, eos['snmp_rocommunity'])
if failmsg:
fails.append(failmsg)
Expand Down