Skip to content

Check CRM limit for route performance test#2461

Merged
vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd:route_perf_fix
Nov 5, 2020
Merged

Check CRM limit for route performance test#2461
vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd:route_perf_fix

Conversation

@vaibhavhd
Copy link
Contributor

Description of PR

Summary: Fix test_route_perf test failure - L3 route add failed with error Table full

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Failure of test_route_perf in S6100 platforms
The test_route_perf test adds the ipv4 and ipv6 routes based on the input arg --num_routes (default 10000 routes)
This test fails where the available limit is less than the number of routes being added.
Error:

['Nov  3 19:08:26.930925 str-s6100-acs-5 ERR syncd#syncd: [none] _brcm_sai_l3_route_config:2078 L3 route add failed with error Table full (0xfffffffa).
ERR syncd#syncd: [none] brcm_sai_create_route_entry:413 L3 route add failed with error -13.
ERR syncd#syncd: :- processEvent: attr: SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID: oid:0x5000000000d21
ERR syncd#syncd: :- processEvent: failed to execute api: create, key: SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"3000:26a0:1::/64","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000042"}, status: SAI_STATUS_TABLE_FULL
ERR syncd#syncd: :- syncd_main: Runtime error: :- processEvent: failed to execute api: create, key: SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"3000:26a0:1::/64","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000042"}, status: SAI_STATUS_TABLE_FULL
ERR swss#orchagent: :- on_switch_shutdown_request: Syncd stopped
WARNING syncd#syncd: :- saiDiscover: skipping since it causes crash: SAI_STP_ATTR_BRIDGE_ID
ERR syncd#syncd: [none] _brcm_sai_port_wred_stats_get:5068 Hardware failure -4 in getting WRED stat 69 for port 1
ERR syncd#syncd: [none] brcm_sai_get_port_stats:2097 port wred stats get failed with error Table empty (0xfffffffb).

How did you do it?

Added a check for setting the route addition limit based on CRM resource availability.

admin@sonic:~$ crm show resources all


Resource Name           Used Count    Available Count
--------------------  ------------  -----------------
ipv4_route                    6475              67253
ipv6_route                    6476               1716

Based on the available count, decide the number of routes to test with.

How did you verify/test it?

Tested test_route_perf test on S6100 platform and it passed without any Table Full errors.

route/test_route_perf.py::test_perf_add_remove_routes[4] passed     [ 50%]
route/test_route_perf.py::test_perf_add_remove_routes[6] passed     [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vaibhavhd vaibhavhd merged commit 3f6242e into sonic-net:master Nov 5, 2020
@vaibhavhd vaibhavhd deleted the route_perf_fix branch November 5, 2020 04:27
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…ic-net#12186)

linkmgrd:
* a0834e4 2022-09-22 | [Active-Active] server side admin forwarding state sync up (sonic-net#133) (HEAD -> 202205) [Jing Zhang]
* ea56020 2022-09-21 | Post switchover reasons to STATE DB (sonic-net#131) [Jing Zhang]

swss:
* d9cbf44 2022-09-24 | [orchagent] Fix issue: ip prefix shall be inited even if VRF/VNET is not ready (sonic-net#2461) (HEAD -> 202205, github/202205) [Junchao-Mellanox]
* 3dcd6ff 2022-09-24 | [macsec]: Set MTU for MACsec (sonic-net#2398) (sonic-net#2466) [Ze Gan]

platform-daemon:
* 48b6239 2022-09-27 | [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Include following commit:
936f1b1 Revert "[config reload]: On dual ToR systems, cache ARP and FDB table… (sonic-net#2461)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants