Remove host interfaces fetching operations from __init__ method of the VMTopology class#2446
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 6, 2020
Merged
Conversation
…e VMTopology class Move the interfaces fetching operations to the init method, and use the update() method to fetch. Signed-off-by: Gord Chen <gord_chen@edge-core.com>
yxieca
approved these changes
Nov 5, 2020
Collaborator
|
@lguohan can you also take a quick look at this change? |
lguohan
reviewed
Nov 5, 2020
lguohan
approved these changes
Nov 5, 2020
3 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: * ab21b58 [202205] check for vxlan mapping before removing vlan (sonic-net#2388) ([sonic-net#2446](sonic-net/sonic-utilities#2446)) * e111ad4 [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (sonic-net#2265) ([sonic-net#2433](sonic-net/sonic-utilities#2433)) * 6925947 [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters ([sonic-net#2406](sonic-net/sonic-utilities#2406)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (improvement)
The _init method of VMTopoogy class calls the ifconfig method to init host_ifaces.
Move to the init method to use the update() method to replace this operation.
The update() method supports the retry mechanism and can avoid the "ifconfig -a"
conflict issue if there are multiple job perform add/remove topo
Signed-off-by: Gord Chen gord_chen@edge-core.com
Type of change
Approach
What is the motivation for this PR?
The update method support retry mechanism
How did you do it?
How did you verify/test it?
Use add/remove topo to test
Any platform specific information?
AS7816-64X
Supported testbed topology if it's a new test case?
Documentation