[LLDP] Fix lldp test to align with a bug fix#2413
Merged
wangxin merged 1 commit intosonic-net:masterfrom Nov 3, 2020
shlomibitton:shlomi_lldp_test_fix
Merged
[LLDP] Fix lldp test to align with a bug fix#2413wangxin merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_lldp_test_fix
wangxin merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_lldp_test_fix
Conversation
sonic-net/sonic-buildimage#5698 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Contributor
Author
|
PR dependency on sonic-net/sonic-buildimage#5698 |
3 tasks
keboliu
approved these changes
Oct 27, 2020
Collaborator
|
Please hold on merging this PR until sonic-net/sonic-buildimage#5698 is merged and backported to 201911 branch. Without sonic-net/sonic-buildimage#5698 in 201911 branch image, the LLDP testing with this commit would fail. |
Collaborator
|
retest vsimage please |
Contributor
Author
|
@yxieca This PR will fail the vsimage build unless sonic-net/sonic-buildimage#5698 is merged. |
3 tasks
Collaborator
|
@shlomibitton @yxieca I have created a PR to temporarily disable LLDP in KVM testing to workaround this mutually dependent issue: #2451 |
wangxin
added a commit
that referenced
this pull request
Nov 3, 2020
…ixes (#2451) PR #2413 and sonic-net/sonic-buildimage#5698 depends on each other. If PR#2413 is not merged, PR#5698 would fail PR test and cannot be merged. If PR#2413 is merged firstly, all sonic-mgmt-pr testing would fail before a new image with PR#5698 is ready. The workaround is to temporarily disable LLDP for sonic-mgmt-pr testing. Merge PR#2413 to unblock PR#5698. After a new image with PR#5698 is ready, then enable LLDP KVM testing again. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
retest this please |
wangxin
approved these changes
Nov 3, 2020
yxieca
added a commit
that referenced
this pull request
Nov 5, 2020
abdosi
pushed a commit
to abdosi/sonic-mgmt
that referenced
this pull request
Nov 27, 2020
…t LLDP fixes (sonic-net#2451)" This reverts commit e547a1d. PR# sonic-net#2413 has already been reverted. sonic-net/sonic-buildimage#5698 will not be merged as this is not valid design. Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com>
abdosi
added a commit
that referenced
this pull request
Nov 27, 2020
…t LLDP fixes (#2451)" (#2595) This reverts commit e547a1d. PR# #2413 has already been reverted. sonic-net/sonic-buildimage#5698 will not be merged as this is not valid design. Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com> Co-authored-by: Abhishek Dosi <abdosi@micrsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…et#12263) To get following fixes: be7da6b [sonic-installer] use host docker startup arguments when running dockerd in chroot (sonic-net#2179) (sonic-net#2407) d112f7c [202205][auto-ts] add memory check (sonic-net#2116) (sonic-net#2413)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
be7da6b [sonic-installer] use host docker startup arguments when running dockerd in chroot (sonic-net#2179) (sonic-net#2407) d112f7c [202205][auto-ts] add memory check (sonic-net#2116) (sonic-net#2413) Signed-off-by: Vivek Reddy <vkarri@nvidia.com> Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
There is a bug fix on PR sonic-net/sonic-buildimage#5698
The test fail after the change, this PR is to align the new change to the test case.
How did you do it?
Parse correct keys from mg_facts.
How did you verify/test it?
Run the test manually after applying the changes on sonic-buildimage and sonic-mgmt.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation