[parametize by ports] add infrastructure to allow test parametized by ports#2411
Merged
yxieca merged 5 commits intosonic-net:masterfrom Oct 28, 2020
Merged
[parametize by ports] add infrastructure to allow test parametized by ports#2411yxieca merged 5 commits intosonic-net:masterfrom
yxieca merged 5 commits intosonic-net:masterfrom
Conversation
… ports
Assumptions:
- Run test_pretest before actual test.
- test_update_testbed_metadata will populate testbed information
and save to tests/metadata/<testbed_name>.json.
Available parameterizes:
- all_ports : all ports available on target testbed.
- oper_up_ports : all ports in oper_up state.
- admin_up_ports : all ports in admin_up state.
- all_pc : all port channel available on target testbed.
- oper_up_pc : all port channel in oper_up state.
- admin_up_pc : all port channel in admin_up state.
Parameter format:
{ 'dut' : <dut name, str>, 'interface' : <port or port channel name, str> }
Expectations:
- when { 'dut' : 'unknown', 'interface' : 'found-no-<port|pc>' } is passed
in as parameter, test should warn and loop through all ports (port channels).
Signed-off-by: Ying Xie <[email protected]>
|
This pull request introduces 1 alert and fixes 1 when merging e9f996a into 4703756 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 4bcdff3 into 553e9ff - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 7591239 into 553e9ff - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging d391ed2 into 553e9ff - view on LGTM.com fixed alerts:
|
3 tasks
neethajohn
approved these changes
Oct 28, 2020
OleksandrKozodoi
added a commit
to OleksandrKozodoi/sonic-mgmt
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Oleksandr Kozodoi <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…#12292) linkmgrd: * a5ac7f6 2022-10-05 | [Active-Active] Post link prober stats to state db (sonic-net#140) (HEAD -> 202205, github/202205) [Jing Zhang] * f4b0e53 2022-10-05 | [Active-Active] Retry config mux mode standby (sonic-net#139) [Jing Zhang] utilities: * a255838 2022-10-04 | [minigraph] new workflow for golden path (sonic-net#2396) (HEAD -> 202205, github/202205) [jingwenxie] * 99425a8 2022-10-03 | [actions] Support Semgrep by Github Actions (sonic-net#2417) [Mai Bui] * f41e4d1 2022-09-30 | Fix for show vxlan tunnel command display issue sonic-net#11902 (sonic-net#2391) [Senthil Bhava] * e1d827e 2022-09-29 | [VxLAN]Fix Vxlan delete command to throw error when there are references (sonic-net#2404) [Sudharsan Dhamal Gopalarathnam] * d77acf8 2022-09-28 | [doc] add documentation on automatic techsupport based on memory (sonic-net#2411) [Stepan Blyshchak] * 2cfc75a 2022-09-28 | [doc] update "config feature" section with "--block" option (sonic-net#2409) [Stepan Blyshchak] * 9dc8471 2022-09-28 | [Vxlanmgrd] [CPA] Update the vxlan_tunnel name len to be under IFNAMIZ to overcome netdev creation failure (sonic-net#2398) [Vivek] * 342589e 2022-10-03 | Added cisco config platform commands (sonic-net#2242) (sonic-net#2418) [yucgu] swss: * 9d9f395 2022-10-04 | [intfmgr]: Enable `accept_untracked_na` kernel param (sonic-net#2436) (HEAD -> 202205, github/202205) [Lawrence Lee] * 6b6d25d 2022-10-04 | [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2480) [Bryan Crossland] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
We want to reduce big loop test cases that loop through for example all ports. test_link_flap.py is one example.
We would like to break these test cases down to individual testcases for each port. so that we can exactly know which port had issue.
With this change, test_link_flap is ready for multi-dut tests.
How did you do it?
Creating infrastructure to loop through all port or port channels, or the subset of oper_up and/or admin_up.
Assumptions:
and save to tests/metadata/<testbed_name>.json.
Available parameterizes:
Parameter format:
"<dut_hostname>|<port_name>" e.g. str-dx010-acs-1|Ethernet8
Please use the provided helper function decode_dut_port_name() to decode into dutname and port name. (see sample code in test_link_flap)
Expectations:
Signed-off-by: Ying Xie [email protected]
How did you verify/test it?
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, xdist-1.28.0, metadata-1.10.0, forked-1.3.0, html-1.22.1, repeat-0.8.0
collected 1 item
platform_tests/test_link_flap.py::test_link_flap[unknown|unknown]
------------------------------------------------------------------------------------- live log call --------------------------------------------------------------------------------------
06:36:55 WARNING test_link_flap.py:__build_test_candidates:74: Failed to get ports enumerated as parameter. Fall back to test all ports
PASSED [100%]
==================================================================================== warnings summary ====================================================================================
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, xdist-1.28.0, metadata-1.10.0, forked-1.3.0, html-1.22.1, repeat-0.8.0
collected 1 item
test_pretest.py::test_update_testbed_metadata PASSED [100%]
------------------------------------------------------------------------ generated xml file: /tmp/logs-01/tr.xml -------------------------------------------------------------------------
=============================================================================== 1 passed in 75.95 seconds ================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, xdist-1.28.0, metadata-1.10.0, forked-1.3.0, html-1.22.1, repeat-0.8.0
collected 32 items
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet8] PASSED [ 3%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet0] PASSED [ 6%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet4] PASSED [ 9%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet108] PASSED [ 12%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet100] PASSED [ 15%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet104] PASSED [ 18%]
platform_tests/test_link_flap.py::test_link_flap[str-dx010-acs-1|Ethernet68] PASSED [ 21%]
... ...