Skip to content

[platform api] Fix argument mismatch in platform API test #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jleveque merged 2 commits into from
Nov 6, 2020
Merged

[platform api] Fix argument mismatch in platform API test #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1ba512
Add is_replaceable and get_position_in_parent test for psu_fan, fan_d…
Junchao-Mellanox Oct 26, 2020
ef083f1
Merge branch 'master' into api-testcase
Junchao-Mellanox Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/common/helpers/platform_api/fan_drawer_fan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,5 @@ def set_status_led(conn, fan_drawer_idx, fan_idx, color):
return fan_drawer_fan_api(conn, fan_drawer_idx, fan_idx, 'set_status_led', [color])


def get_status_led(conn, fan_idx):
def get_status_led(conn, fan_drawer_idx, fan_idx):
return fan_drawer_fan_api(conn, fan_drawer_idx, fan_idx, 'get_status_led')
3 changes: 2 additions & 1 deletion tests/common/helpers/platform_api/psu_fan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def get_position_in_parent(conn, psu_idx, fan_idx):

def is_replaceable(conn, psu_idx, fan_idx):
return psu_fan_api(conn, psu_idx, fan_idx, 'is_replaceable')

#
# Methods defined in fanBase class
#
Expand Down Expand Up @@ -76,5 +77,5 @@ def set_status_led(conn, psu_idx, fan_idx, color):
return psu_fan_api(conn, psu_idx, fan_idx, 'set_status_led', [color])


def get_status_led(conn, fan_idx):
def get_status_led(conn, psu_idx, fan_idx):
return psu_fan_api(conn, psu_idx, fan_idx, 'get_status_led')
1 change: 1 addition & 0 deletions tests/platform_tests/api/test_fan_drawer_fans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ def test_is_replaceable(self, platform_api_conn):
replaceable = fan_drawer_fan.is_replaceable(platform_api_conn, j, i)
if self.expect(replaceable is not None, "Failed to perform is_replaceable for drawer {} fan {}".format(j, i)):
self.expect(isinstance(replaceable, bool), "Replaceable value must be a bool value for drawer {} fan {}".format(j, i))

self.assert_expectations()

#
Expand Down
1 change: 1 addition & 0 deletions tests/platform_tests/api/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ def test_is_replaceable(self, platform_api_conn):
replaceable = module.is_replaceable(platform_api_conn, i)
if self.expect(replaceable is not None, "Failed to perform is_replaceable for module {}".format(i)):
self.expect(isinstance(replaceable, bool), "Replaceable value must be a bool value for module {}".format(i))

self.assert_expectations()

#
Expand Down
1 change: 1 addition & 0 deletions tests/platform_tests/api/test_psu_fans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ def test_is_replaceable(self, platform_api_conn):
replaceable = psu_fan.is_replaceable(platform_api_conn, j, i)
if self.expect(replaceable is not None, "Failed to perform is_replaceable for PSU {} fan {}".format(j, i)):
self.expect(isinstance(replaceable, bool), "Replaceable value must be a bool value for PSU {} fan {}".format(j, i))

self.assert_expectations()

#
Expand Down