[Platform API][SFP] Remove 'skip_sanity=True' pytest marker#2395
Merged
wangxin merged 1 commit intosonic-net:masterfrom Oct 23, 2020
jleveque:no_skip_sanity_sfp
Merged
[Platform API][SFP] Remove 'skip_sanity=True' pytest marker#2395wangxin merged 1 commit intosonic-net:masterfrom jleveque:no_skip_sanity_sfp
wangxin merged 1 commit intosonic-net:masterfrom
jleveque:no_skip_sanity_sfp
Conversation
vdahiya12
approved these changes
Oct 22, 2020
wangxin
approved these changes
Oct 23, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: 94a3436 [show] vnet endpoint [ip/ipv6] command (2342) (sonic-net#2421) 84a0712 [VxLAN]Fix Vxlan delete command to throw error when there are references (sonic-net#2404) 1341f58 [202012] [generate_dump]: Enhance show techsupport for cisco-8000 platform (sonic-net#2395) Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Remove 'skip_sanity=True' pytest marker from SFP platform API test file
Type of change
Approach
What is the motivation for this PR?
To ensure no tests skip the sanity check, which is useful for helping determine if a test has left the device in a bad state
How did you do it?
Remove 'skip_sanity=True' pytest marker from SFP platform API test file, which must have slipped in in a previous PR
How did you verify/test it?
Run the tests in the module
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation