[conn_graph] improve graph facts collector#2374
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 20, 2020
Merged
Conversation
- Collect first element of list. - Collect full variable for non-list variables. Signed-off-by: Ying Xie <[email protected]>
lguohan
approved these changes
Oct 20, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-swss submodule pointer to include the following: * VxLAN Tunnel Counters and Rates implementation (sonic-net#1859) ([sonic-net#2442] * Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" ([sonic-net#2374]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Nightly test are all failing due to regression in conn_graph_facts.py.
How did you do it?
Signed-off-by: Ying Xie [email protected]
How did you verify/test it?
Run test on physical DUT. Without fix:
E RunAnsibleModuleFail: run module conn_graph_facts failed, Ansible Results =>
E {
E "changed": false,
E "failed": true,
E "invocation": {
E "module_args": {
E "anchor": null,
E "filename": "/var/src/sonic-mgmt/tests/common/fixtures/../../../ansible/files/starlab_connection_graph.xml",
E "filepath": null,
E "host": "str-dx010-acs-1",
E "hosts": null
E }
E },
E "msg": "Traceback (most recent call last):\n File "/tmp/ansible_conn_graph_facts_payload_PAqL5h/main.py", line 348, in main\n results = {k: v[0] for k, v in results.items()}\n File "/tmp/ansible_conn_graph_facts_payload_PAqL5h/main.py", line 348, in \n results = {k: v[0] for k, v in results.items()}\nKeyError: 0\n"
E }
With the fix, test passes.