[pfcwd] Filter rx ports out of test ports#2355
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 19, 2020
Merged
Conversation
If port `A` is used as test port and rx port for port `B`, and the test conducts `storm_restore_path` over port `B` prior to port `A`. The traffic verification for port `B` will fail because it uses port `A` as rx port, which is currently in stormed state. So filter out those ports that act as rx port out of selected test ports. Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
fix_pfcwd_wb_test_ports
branch
from
0f7c22f to
cee5870
Compare
yxieca
approved these changes
Oct 16, 2020
yxieca
reviewed
Oct 16, 2020
neethajohn
reviewed
Oct 16, 2020
neethajohn
approved these changes
Oct 19, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…x-kernel] advance submodule head (sonic-net#12025) linkmgrd: * ab5b2c1 2022-09-02 | Fix mux config (sonic-net#128) (HEAD -> 202205, github/202205) [Longxiang Lyu] utilities: * 7de9305 2022-09-07 | [generate dump]Added error message when saisdkdump fails (sonic-net#2356) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * c5b0a6d 2022-09-07 | [counterpoll]Fixing counterpoll show for tunnel and acl stats (sonic-net#2355) [Sudharsan Dhamal Gopalarathnam] * 1452b44 2022-09-05 | [GCU] Fix missing backend in dry run (sonic-net#2347) [jingwenxie] * bc7b845 2022-09-04 | Add Password Hardening CLI support (sonic-net#2338) [davidpil2002] * 55e8948 2022-09-06 | [fast-reboot]Avoid stopping masked services during fast-reboot (sonic-net#2335) [Sudharsan Dhamal Gopalarathnam] * f7d69d4 2022-08-30 | Replace cmp in acl_loader with operator.eq (sonic-net#2328) [Zhaohui Sun] * 4054ebb 2022-09-05 | Add verification for override (sonic-net#2305) [jingwenxie] * 729d811 2022-05-30 | Fix sonic-installer and 'show version' command crash when database docker not running issue. (sonic-net#2183) [Hua Liu] platform-daemons: * 36ba7c0 2022-09-07 | [ycable] cleanup logic for creating grpc future ready (sonic-net#289) (HEAD -> 202205) [vdahiya12] * 2a9db73 2022-09-01 | [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) [vdahiya12] platform-common: * d7c990d 2022-09-03 | [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready (sonic-net#305) (HEAD -> 202205) [Kebo Liu] linux-kernel: * 25ea052 2022-08-31 | [patch]: Add accpt_untracked_na kernel param (sonic-net#292) (HEAD -> 202205) [Lawrence Lee] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
If port
Ais used as test port and rx port for portB, and the testconducts
storm_restore_pathover portBprior to portA. Thetraffic verification for port
Bwill fail because it uses portAasrx port, which is currently in stormed state.
So filter out those ports that act as rx port out of selected test
ports.
Signed-off-by: Longxiang Lyu [email protected]
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
If a port is used as the rx port, it cannot be used as a test port in
pfcwdtests since it might be in stormed state, and the traffic verification will fail.How did you do it?
Remove all ports as rx ports from test ports.
How did you verify/test it?
Any platform specific information?
Test over Arista7260, it is more likely to reproduce with DUT that has more ports.
Supported testbed topology if it's a new test case?
Documentation