Add Multi-VRF testbed setup guidance.#23461
Add Multi-VRF testbed setup guidance.#23461yutongzhang-microsoft wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
7cb7b97 to
abfaee3
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
|
||
|
|
||
| ## Overview | ||
| In a standard testbed, each BGP neighbor device maps to its own dedicated cEOSLab container. |
There was a problem hiding this comment.
better have a link to VsSetup md.
There was a problem hiding this comment.
Add the link to VsSetup md. "see VsSetup for general testbed setup"
|
|
||
|
|
||
| ## Overview | ||
| In a standard testbed, each BGP neighbor device maps to its own dedicated cEOSLab container. |
There was a problem hiding this comment.
not just cEOS container, but it can also be cSONiC or others, will be better to make it generic.
There was a problem hiding this comment.
Changed to "neighbor container (e.g. cEOS, cSONiC)"
| For large topologies, this requires a large number of containers, placing significant memory | ||
| and CPU demands on the host server. | ||
|
|
||
| Multi-VRF mode converges the total number of peer switches into the fewest possible number of cEOSLab |
There was a problem hiding this comment.
converges total number of peer switches into the fewest possible number of cEOSLab
converges large number of peer switches into the fewest possible number of neighbor containers
| dataplane behavior are unchanged. | ||
|
|
||
| ## Approach | ||
| cEOSLab peers in docker containers may be converged into a smaller number of host peers. |
There was a problem hiding this comment.
don't limit the approach to cEOS only.
There was a problem hiding this comment.
Changed to "Neighbor containers (e.g. cEOS, cSONiC)"
| dataplane behavior are unchanged. | ||
|
|
||
| ## Approach | ||
| cEOSLab peers in docker containers may be converged into a smaller number of host peers. |
There was a problem hiding this comment.
also it is rare to call them cEOSLab.... we usually just call it cEOS
There was a problem hiding this comment.
Changed in whole page.
| ... | ||
| use_converged_peers: true | ||
| ``` | ||
| This file is read by the `TestbedProcessing.py` script, which sets global variables |
There was a problem hiding this comment.
We should have a workflow to show the high level how the process works. For people don't know about this script and where it is placed in the workflow. this section doesn't help at all.
| ./testbed-cli.sh redeploy-topo <testbed-name> password.txt | ||
| ``` | ||
|
|
||
| ### Manual convergence (optional) |
There was a problem hiding this comment.
is this a step 4? or another way to enable it. if it is latter one, we should use right heading level
## Enabling Multi-VRF mode
### Approach #1: Use use_converged_peer flag in testbed.yaml
### Approach ##: Manual converge peer nodes
There was a problem hiding this comment.
'Manual convergence' is just an alternative way to modify the YAML files — you can either edit them through ·TestbedProcessing.py· or manually call converge_testbed to achieve the same result.
| ``` | ||
|
|
||
| ### Step 3: Redeploy topology | ||
| ```buildoutcfg |
There was a problem hiding this comment.
what is buildoutcfg?
should this be bash?
| BGP neighborship. | ||
|
|
||
| ## Known Limitations | ||
| + cEOSLab instances do not allow for the creation of interfaces with interface-IDs greater |
There was a problem hiding this comment.
same here, don't limit us to cEOS. cSONiC can also support this mode.
|
|
||
| ## Test Library Changes | ||
| Test libraries needed to be made aware of the new underlying structure of cEOSLab | ||
| containers, VRFs, and BGP adjacencies. In many cases this was done by reference to the |
There was a problem hiding this comment.
this section is too vague. we should call out the patterns and examples here.
also call out what changes we need in the common infra to support this mode.
|
AI agent on behalf of Ying.\n\nIssues found: docs-only.\n\n |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Thanks for the review! Here's a summary of the changes made to address all comments:
|
dfd3d36 to
f88fd54
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Made two additional updates based on feedback: 1. Enabling Multi-VRF Mode — restructured Removed the Approach #1 / Approach #2 split. The section is now a straightforward Step 1–3 workflow. The manual convergence section has been rewritten to clarify that it is a fallback for cases where 2. Test Library Changes — rewritten based on actual code (PR #22171) The section now describes each file changed with accurate details:
|
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
22c7979 to
9b45a50
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
e721d49 to
1630995
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
AI agent on behalf of Ying. Issues found:
|
Description of PR
Add documentation for Multi-VRF testbed setup, which converges multiple cEOSLab BGP peer
containers into fewer host containers using VRFs to reduce resource consumption on large-scale
topologies.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add documentation for Multi-VRF testbed setup, which converges multiple cEOSLab BGP peer
containers into fewer host containers using VRFs to reduce resource consumption on large-scale
topologies.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation