Skip to content

[action] [PR:23342] fix(console): fix intermittent login failures in dut_console tests #23396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mssonicbld merged 1 commit into from
Mar 30, 2026
+6 −3
Merged

[action] [PR:23342] fix(console): fix intermittent login failures in dut_console tests #23396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/common/connections/ssh_console_conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ def login_stage_2(self,
user_sent = True

# Search for password pattern / send password
if user_sent and not password_sent and re.search(pwd_pattern, output, flags=re.I):
# Use return_msg (accumulated) instead of output to handle cases where
# 'Password:' prompt is split across multiple TCP reads (e.g. 'Pa' + 'ssword:')
if user_sent and not password_sent and re.search(pwd_pattern, return_msg, flags=re.I):
self.write_channel(password + self.RETURN)
time.sleep(0.5 * delay_factor)
output = self.read_channel()
Expand Down
5 changes: 3 additions & 2 deletions tests/dut_console/test_idle_timeout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import time

import pytest

from tests.common.helpers.assertions import pytest_assert
Expand All @@ -17,12 +18,12 @@
def test_timeout(duthost_console, duthosts, enum_supervisor_dut_hostname):
duthost = duthosts[enum_supervisor_dut_hostname]
logger.info("Get default session idle timeout")
default_tmout = duthost_console.send_command('echo $TMOUT')
default_tmout = duthost_console.send_command('echo $TMOUT').strip().splitlines()[0].strip()
pytest_assert(default_tmout == DEFAULT_TMOUT, "default timeout on dut is not {} seconds".format(DEFAULT_TMOUT))

logger.info("Set session idle timeout")
duthost_console.send_command('export TMOUT={}'.format(SET_TMOUT))
set_tmout = duthost_console.send_command('echo $TMOUT')
set_tmout = duthost_console.send_command('echo $TMOUT').strip().splitlines()[0].strip()
pytest_assert(set_tmout == SET_TMOUT, "set timeout fail")

time.sleep(15)
Expand Down
Loading