Add DOM post-test deviation attributes, telemetry profiling TC by mihirpat1 · Pull Request #23356 · sonic-net/sonic-mgmt

mihirpat1 · 2026-03-26T20:15:33Z

Description of PR

Summary:
Add post-test deviation validation attributes, a new telemetry update interval profiling test case, and clarify prerequisite failure behavior in DOM and system test plans.

Type of change

Back port request

Approach

What is the motivation for this PR?

Tests that restore the port to steady-state operation (e.g., interface shutdown/startup, DOM polling toggle) had no way to verify that sensor readings returned to acceptable levels. Additionally, there was no test to profile DOM telemetry update intervals for cross-release regression detection. Finally, the prerequisite failure behavior was undocumented.

How did you do it?

Please refer to the HLD diff

How did you verify/test it?

Documentation-only change — reviewed for internal consistency across attribute table, example JSON, post-test deviation rule, and test case steps/expected results.

Any platform specific information?

N/A — deviation attributes are optional and configured per-transceiver in dom.json.

Supported testbed topology if it's a new test case?

N/A — test plan documentation update only.

Documentation

Updated docs/testplan/transceiver/dom_test_plan.md and docs/testplan/transceiver/system_test_plan.md.

MSFT ADO - 37280302

mssonicbld · 2026-03-26T20:15:42Z

/azp run

Copilot

Pull request overview

Updates the transceiver DOM and system test plan documentation to add configurable post-test deviation validation attributes and define a new telemetry update interval profiling test case, while clarifying prerequisite failure behavior.

Changes:

Documented new DOM post-test deviation attributes (upper/lower bounds) and added a post-test deviation validation rule.
Added a new “Telemetry update interval profiling” advanced DOM test case with configurable polling interval/duration attributes.
Clarified prerequisite-test failure semantics in both DOM and system test plans.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
docs/testplan/transceiver/dom_test_plan.md	Adds new post-test deviation attributes/rule, updates `dom.json` example, expands advanced test cases, and introduces telemetry update interval profiling TC.
docs/testplan/transceiver/system_test_plan.md	Adds a note documenting how prerequisite test case failures affect dependent system test cases.

docs/testplan/transceiver/dom_test_plan.md

mssonicbld · 2026-03-26T20:46:46Z

/azp run

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

docs/testplan/transceiver/dom_test_plan.md

mssonicbld · 2026-03-26T20:58:09Z

/azp run

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-03-26T20:58:58Z

/azp run

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

docs/testplan/transceiver/dom_test_plan.md

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-03-26T21:11:56Z

/azp run

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

bfoo-msft · 2026-03-27T17:07:23Z

docs/testplan/transceiver/dom_test_plan.md

+| telemetry_profile_poll_interval_sec | integer | 10 | O | transceivers or platform_hwsku_overrides | Polling interval in seconds for the telemetry update profiling test |
+| telemetry_profile_duration_min | integer | 10 | O | transceivers or platform_hwsku_overrides | Duration in minutes to run the telemetry update profiling test |
+
+**Post-test range rule:** For tests that restore a port to steady-state operation, verify each post-test DOM reading falls within its configured `{"min", "max"}` range. The check applies only to attributes that are present in the configuration (`min <= post-test value <= max`). Lane-based entries such as TX bias and TX/RX power use the `LANE_NUM` expansion and are validated per lane. The test fails if any enabled field falls outside its configured range.


It would be good to clarify that the post-check is looking for relative changes based on the first (or average) measurement. Something like min <= post-test value - first-read value <= max

@bfoo-msft Addressed this now

bfoo-msft · 2026-03-27T17:10:46Z

docs/testplan/transceiver/dom_test_plan.md

          "MMA1T00-VS-400G": {
-            "temperature_threshold_range": {"lowalarm": -30.0, "lowwarning": -10.0, "highwarning": 75.0, "highalarm": 85.0}
+            "temperature_threshold_range": {"lowalarm": -30.0, "lowwarning": -10.0, "highwarning": 75.0, "highalarm": 85.0},
+            "voltage_deviation_range": {"min": 3.25, "max": 3.45},


These thresholds use absolute values, not relative values.
Suggestions are:
"voltage_deviation_range": {"min": -0,2, "max": 0,2},
"laser_temperature_deviation_range": {"min": -10, "max": 10},
"txLANE_NUMbias_deviation_range": {"min": -5, "max": 5},
"txLANE_NUMpower_deviation_range": {"min": -0.2, "max": 0.2},
"rxLANE_NUMpower_deviation_range": {"min": -0.5, "max": 0.5}

@bfoo-msft Addressed this now

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mssonicbld · 2026-03-27T17:31:22Z

/azp run

azure-pipelines · 2026-03-27T17:31:29Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

yxieca · 2026-03-28T02:06:59Z

AI agent on behalf of Ying.\n\nI found issues that need attention.\n\n

yxieca

AI agent on behalf of Ying. Reviewed; no issues found.

mihirpat1 requested a review from Copilot March 26, 2026 20:15

Copilot started reviewing on behalf of mihirpat1 March 26, 2026 20:16 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

docs/testplan/transceiver/dom_test_plan.md Outdated Show resolved Hide resolved

docs/testplan/transceiver/dom_test_plan.md Outdated Show resolved Hide resolved

docs/testplan/transceiver/dom_test_plan.md Outdated Show resolved Hide resolved

mihirpat1 requested a review from Copilot March 26, 2026 20:46

Copilot started reviewing on behalf of mihirpat1 March 26, 2026 20:47 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

docs/testplan/transceiver/dom_test_plan.md Outdated Show resolved Hide resolved

mihirpat1 and others added 3 commits March 26, 2026 20:58

Add DOM post-test deviation attributes, telemetry profiling TC

99e8d2d

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Apply suggestions from code review

605fadd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Mihir Patel <patelmi@microsoft.com>

Correcte term for range

1743d52

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mihirpat1 force-pushed the dom-deviation-attrs-telemetry-tc branch from b7696fb to 1743d52 Compare March 26, 2026 20:58

mihirpat1 requested a review from Copilot March 26, 2026 20:59

Copilot started reviewing on behalf of mihirpat1 March 26, 2026 20:59 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

docs/testplan/transceiver/dom_test_plan.md Outdated Show resolved Hide resolved

Renamed attributes

0b81f16

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

mihirpat1 requested a review from Copilot March 26, 2026 21:13

Copilot started reviewing on behalf of mihirpat1 March 26, 2026 21:13 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

mihirpat1 mentioned this pull request Mar 26, 2026

[Transceiver onboarding] Add EEPROM, System and DOM test attributes in HLD #20359

Merged

11 tasks

Copilot AI mentioned this pull request Mar 27, 2026

Review all human-authored PRs opened in the past 24 hours in sonic-net/sonic-mgmt #23365

Draft

mihirpat1 requested a review from prgeor March 27, 2026 03:35

bfoo-msft reviewed Mar 27, 2026

View reviewed changes

Addressed PR comments

bce0545

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

yxieca approved these changes Mar 28, 2026

View reviewed changes

Conversation

mihirpat1 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mssonicbld commented Mar 26, 2026

Uh oh!

mssonicbld commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mssonicbld commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bfoo-msft Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

mihirpat1 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

bfoo-msft Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

mihirpat1 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Mar 27, 2026

Uh oh!

azure-pipelines bot commented Mar 27, 2026

Uh oh!

yxieca commented Mar 28, 2026

Uh oh!

yxieca left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mihirpat1 commented Mar 26, 2026 •

edited

Loading