[container_upgrade] Convert parameters.json from string to list format#23343
Open
wangxinbot wants to merge 1 commit intosonic-net:masterfrom
Open
[container_upgrade] Convert parameters.json from string to list format#23343wangxinbot wants to merge 1 commit intosonic-net:masterfrom
wangxinbot wants to merge 1 commit intosonic-net:masterfrom
Conversation
Convert docker parameters from single string format to list format for better readability and to align with the internal repo format, reducing merge conflicts during public-to-internal sync. Update create_parameters_mapping() to join the list with spaces, producing the same runtime result as before. Co-authored-by: Copilot <[email protected]> Signed-off-by: Xin Wang <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@maipbui Can you help review this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Convert docker parameters in
parameters.jsonfrom single string format to list format for better readability and to align with the internal repo format, reducing merge conflicts during public-to-internal sync.Update
create_parameters_mapping()to join the list with spaces, producing the same runtime result as before.Type of change
Back port request
Approach
What is the motivation for this PR?
The internal repo uses list format for docker parameters in
parameters.json, while the public repo uses string format. This difference causes merge conflicts every time we sync public to internal. By aligning the format, future syncs will be clean.How did you do it?
parameters.jsonentries from strings (e.g.,"param1 param2") to lists (e.g.,["param1", "param2"])create_parameters_mapping()incontainer_upgrade_helper.pyto use' '.join(details['parameters'])to reconstruct the string at runtimeHow did you verify/test it?
The
create_parameters_mapping()function joins the list back into a space-separated string, producing identical output to the previous string format. The docker run commands are unchanged.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A - existing test improvement
Documentation
N/A