Add non-unicast noise filter to LossyQueueTest ingress drop checks#23340
Open
XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
Open
Add non-unicast noise filter to LossyQueueTest ingress drop checks#23340XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
XuChen-MSFT wants to merge 1 commit intosonic-net:masterfrom
Conversation
Extend the ignore_ingress_drop_caused_by_nonunicast_noise() function (introduced in PR sonic-net#22871 for PFCtest/PFCXonTest) to also cover LossyQueueTest. Environmental broadcast/multicast traffic causes false positive ingress drop failures in LossyQueueTest, same root cause as the PFC tests. Applied to both ingress drop check points in LossyQueueTest: 1. Short-of-drop phase: no ingress drop expected 2. Post-excess-traffic phase: no ingress drop expected (non-DNX) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Extend the
ignore_ingress_drop_caused_by_nonunicast_noise()function (introduced in PR #22871 for PFCtest/PFCXonTest) to also cover LossyQueueTest.PR #22871 added non-unicast noise filtering to PFCtest and PFCXonTest, but missed LossyQueueTest. Environmental broadcast/multicast traffic causes false positive ingress drop failures in LossyQueueTest with the same root cause.
Type of change
Back port request
Approach
What is the motivation for this PR?
LossyQueueTest has the same false positive ingress drop issue as PFCtest/PFCXonTest. Environmental broadcast/multicast traffic (ARP, IPv6 NS/RA) arrives during testing and causes InDiscard counter increases unrelated to test traffic. PR #22871 fixed this for PFCtest/PFCXonTest but did not cover LossyQueueTest.
Kusto analysis shows LossyQueueTest still fails at 33% rate on SONiC.20251110.x across multiple platforms (Cisco-8101, Arista-7060X6, etc.) even after PR #22871.
How did you do it?
Applied the same
ignore_ingress_drop_caused_by_nonunicast_noise()wrapper to both ingress drop check points in LossyQueueTest:How did you verify/test it?
Code review. Same pattern as PR #22871 which was verified on Cisco-8000 chassis topology.
Any platform specific information?
Counter margin (COUNTER_MARGIN) applied for broadcom-dnx, cisco-8000, and marvell-teralynx platforms.
ADO PBIs: #37142761