tests_mark_conditions: skip test_reboot on SN5640#23303
Open
Pterosaur wants to merge 1 commit intosonic-net:masterfrom
Open
tests_mark_conditions: skip test_reboot on SN5640#23303Pterosaur wants to merge 1 commit intosonic-net:masterfrom
Pterosaur wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
force-pushed
the
zegan/skip_sn5640_hash_reboot
branch
from
6032109 to
77d423b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add skip mark for hash/test_generic_hash.py::test_reboot on x86_64-nvidia_sn5640-r0 platform. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
zegan/skip_sn5640_hash_reboot
branch
from
77d423b to
2519e55
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
added
Request for msft-202412 Branch
Request for 202511 branch
yxieca
approved these changes
Mar 26, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
Pterosaur
added a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 26, 2026
Add skip mark for hash/test_generic_hash.py::test_reboot on x86_64-nvidia_sn5640-r0 platform. Upstream PR: sonic-net#23303 ---- #### AI description (iteration 1) #### PR Classification Test configuration update to skip a failing test on a specific hardware platform. #### PR Summary Adds the `x86_64-nvidia_sn5640-r0` platform to the skip conditions for the `test_reboot` test in the generic hash test suite due to platform-specific limitations. - `tests_mark_conditions.yaml`: Added `x86_64-nvidia_sn5640-r0` platform to the skip conditions list for `hash/test_generic_hash.py::test_reboot` test, alongside existing skips for Mellanox SPC1 and Broadcom platforms. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add skip mark for
hash/test_generic_hash.py::test_rebootonx86_64-nvidia_sn5640-r0platform because warm reboot is not supported on this platform.Type of change
Back port request
Approach
What is the motivation for this PR?
test_rebootintest_generic_hash.pyconsistently fails onx86_64-nvidia_sn5640-r0because warm reboot is not supported on this platform.How did you do it?
Added skip entry in
tests/common/plugins/conditional_mark/tests_mark_conditions.yamlfor platformx86_64-nvidia_sn5640-r0with reason explaining warm reboot is not supported.How did you verify/test it?
Verified the YAML syntax and confirmed the conditional mark system picks up the new entry.
Any platform specific information?
Applies to
x86_64-nvidia_sn5640-r0platform only.Documentation
N/A