Skip to content

fix(console): skip extra newline after username in login_stage_2() #23295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StormLiangMS merged 1 commit into from
Mar 26, 2026
Merged

fix(console): skip extra newline after username in login_stage_2() #23295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/common/connections/ssh_console_conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ def login_stage_2(self,
msg = "Login failed: {}".format(self.host)
raise NetMikoAuthenticationException(msg)

self.write_channel(self.RETURN)
# Only send blank CR to wake up terminal when still waiting for username prompt;
# once username has been sent, stop sending CRs so no empty password arrives before 'Password:' prompt
if not user_sent:
self.write_channel(self.RETURN)
time.sleep(0.5 * delay_factor)
i += 1
except EOFError:
Expand Down
Loading