Skip to content

[202505] [docker-ptf] Modify docker container pull setting (#21560)#23224

Merged
StormLiangMS merged 1 commit intosonic-net:202505from
auspham:austinpham/36979761-cherry-pick-21560
Mar 24, 2026
Merged

[202505] [docker-ptf] Modify docker container pull setting (#21560)#23224
StormLiangMS merged 1 commit intosonic-net:202505from
auspham:austinpham/36979761-cherry-pick-21560

Conversation

@auspham
Copy link
Copy Markdown
Contributor

@auspham auspham commented Mar 23, 2026

Set pull to 'missing' to avoid pulling and overwriting the local image if there is a preloaded image present. This is used for testing PR built image which is preloaded in elastic test when PTF_MODIFIED is True. This mechanism is used to test PR built docker-ptf image.

Description of PR

Summary: Cherry-pick #21560. This will allow ptf_modified to be used during add-topo

Since we already have #23188. We need to have this to allow test plan to apply custom ptf on add-topo.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Motivation is test security changes on sonic-net/sonic-buildimage#26265. I noticed my adjustment does not apply to sonic-mgmt test plan for 202505

How did you do it?

Cherry-pick the missing PR that allow testplan to pull from our build

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham changed the title [docker-ptf] Modify docker container pull setting (#21560) [202505] [docker-ptf] Modify docker container pull setting (#21560) Mar 23, 2026
Set pull to 'missing' to avoid pulling and overwriting the local image if there is a preloaded image present. This is used for testing PR built image which is preloaded in elastic test when PTF_MODIFIED is True. This mechanism is used to test PR built docker-ptf image.

Signed-off-by: opcoder0 <[email protected]>
Signed-off-by: Austin Pham <[email protected]>
@auspham auspham force-pushed the austinpham/36979761-cherry-pick-21560 branch from 5c30356 to a025244 Compare March 23, 2026 23:19
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit ee62e44 into sonic-net:202505 Mar 24, 2026
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants