Convert 'read_mac' ansible test to pytest

[ayurkiv-nvda]

Signed-off-by: Andriy Yurkiv [email protected]

Description of PR

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

Migrating tests from ansible to pytest framework

How did you do it?

Converted read_mac ansible test to pytest.
Old ansible test :https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/tasks/read_mac_metadata.yml

How did you verify/test it?

py.test read_mac/test_read_mac_metadata.py --iteration <iter> --image1 <image1URL> --image2 <image2URL> --minigraph1 <file1> --minigraph2 <file2> --inventory ../ansible/inventory --host-pattern <host> --module-path ../ansible/library/  --testbed <host>-<topology> --testbed_file ../ansible/testbed.csv --show-capture=no --capture=no --log-cli-level info -ra

iteration, image1 and image2 params are mandatory
minigraph1 and minigraph2 are optional

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

any

Documentation

'read mac' test flow:

• Download sonic image
• Install it
• Reboot
• Apply new minigraph (optional)
• Check if MAC is correct on interfaces
• Check MTU on interfaces
• Repeat N times with different images

Note
This test has at least 2 parameters that cannot be defined as default (image1 and image2)
Because of this backward compatibility currently does not work (I mean ability to run test using ansible-playbook)

ansible-playbook test_sonic.yml -i inventory --limit {DUT_NAME} -e testbed_name={TESTBED_NAME} -e testbed_type={TESTBED_TYPE} -e testcase_name=read_mac -e iterations={ITERATIONS} -e image1={IMAGE1} -e image2={IMAGE2}

Current implementation of ansible to pytest wrapper does not allow to pass python input params. And this may be motivation to improve it fuctionality in future

[ghost]

All CLA requirements met.

[wangxin]

This test checked router MAC address in config_db after image upgrade and minigraph loading. Would it be easier to add a router MAC check in the upgrading tests than creating a new test?

[ayurkiv-nvda]

This test checked router MAC address in config_db after image upgrade and minigraph loading. Would it be easier to add a router MAC check in the upgrading tests than creating a new test?

This test was written to verify some specific flow. There was a bug, when sometimes after sonic upgrade there wasn't MAC address on interfaces. Firstly was developed YML script to reproduce this issue (cyclic upgrade), then this script was modified and commited to sonic-mgmt repository. And now I manage to rewrite this test to pytest
So I think that it a good idea do not throw away this test, because it helps to validate this specific flow (cyclic sonic upgrade)

[wangxin]

@ayurkiv-nvda You made a point of cylic sonic upgrade. Can you please address my other comments?

[ayurkiv-nvda]

@wangxin I fixed all your comments. Can you please approve and merge if there are no more remarks?
Thank you!

[keboliu]

retest vsimage please

[wangxin]

retest this please