Fix multiple issues in test_mgmtvrf.py#2319
Merged
wangxin merged 1 commit intosonic-net:masterfrom Oct 15, 2020
wangxin:refactor-mgmtvrf-pr
Merged
Fix multiple issues in test_mgmtvrf.py#2319wangxin merged 1 commit intosonic-net:masterfrom wangxin:refactor-mgmtvrf-pr
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:refactor-mgmtvrf-pr
Conversation
* Get rid of global variable * Get the snmp community from the creds fixture * Use the mgmt_ip attribute to get IP address of DUT and PTF * Disable log analyzer for reboot related cases * Move the definition of some constants to head of script file Signed-off-by: Xin Wang <xiwang5@microsoft.com>
daall
approved these changes
Oct 14, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… advance submodule head (sonic-net#11859) linkmgrd: * 9a993b2 2022-08-23 | [active-active] Remove unnecessary mux wait timeout logs (sonic-net#122) (HEAD -> 202205) [Jing Zhang] utilities: * ec4b09f 2022-08-26 | Handle non-front-panel ports in is_rj45_port (sonic-net#2327) (HEAD -> 202205, github/202205) [Stephen Sun] * 4adf897 2022-08-20 | Fix issue: port_type is referenced before initialized (sonic-net#2323) [Stephen Sun] * 314bafd 2022-08-25 | [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) [Ze Gan] * e0166a0 2022-08-25 | portconfig option to configure Tx power and laser frequency of ZR transceiver module (sonic-net#2197) (sonic-net#2330) [Prince George] swss-common: * af80c12 2022-06-30 | [select] break the select loop if interrupt_on_signal flag is set (sonic-net#624) (HEAD -> 202205, github/202205) [Stepan Blyshchak] sairedis: * a1796a5 2022-07-28 | Add support of mdio IPC server class using sai switch api and unix socket (sonic-net#1080) (HEAD -> 202205) [Jiahua Wang] platform-common: * c1ee4b1 2022-08-20 | [CMIS] Catch Exception to avoid CMIS code crash (sonic-net#299) (HEAD -> 202205) [Kebo Liu] * 638d225 2022-07-13 | Fix Cmis memmap field offset (sonic-net#290) [Prince George] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Fix multiple issues in test_mgmtvrf.py
Type of change
Approach
What is the motivation for this PR?
The test_mgmtvrf.py script still has some issues. This PR is to address the issues.
How did you do it?
How did you verify/test it?
Test run the updated script with log analyzer enabled, all cases passed except the test_ntp case failed on Mellanox platform because of some bad NTP related logs in syslog. This is not test issue.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation