[action] [PR:23130] Loganalyzer ignore tam st stats#23140
Merged
mssonicbld merged 1 commit intosonic-net:202511from Mar 19, 2026
Merged
[action] [PR:23130] Loganalyzer ignore tam st stats#23140mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld merged 1 commit intosonic-net:202511from
Conversation
Some platforms do not support TAM (Telemetry and Monitoring) ST (Stream Telemetry) Stats capabilities. When the function sai_query_stats_st_capability is called on these platforms, it returns SAI_STATUS_NOT_SUPPORTED (error -2). This error is expected behavior on platforms without TAM ST support and should not cause test failures. This patch adds the error to the loganalyzer ignore list to prevent false test failures. Signed-off-by: Pratik Dam <pdam@arista.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
requested review from
ZhaohuiS,
wangxin and
xwjiang-ms
as code owners
12 tasks
Collaborator
Author
|
Original PR: #23130 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some older platforms like Broadcom TH2/TD3 do not
support TAM (Telemetry and Monitoring) ST (Stream Telemetry) Stats capabilities.
When the function sai_query_stats_st_capability is called on these platforms,
it returns SAI_STATUS_NOT_SUPPORTED (error -2).
This error is expected behavior on platforms without TAM ST
support and should not cause test failures. This patch adds
the error to the loganalyzer ignore list to prevent false
test failures.
Summary:
Fixes #22893
Type of change
Back port request
Approach
What is the motivation for this PR?
During test execution on platforms that don't support TAM (Telemetry and Monitoring) ST (Stream Telemetry) Stats capabilities, the loganalyzer detects the following error message and causes tests to fail:
ERR syncd#syncd: [none] SAI_API_SWITCH:sai_query_stats_st_capability: Get TAM ST Stats capabilities failed with error -2
This error is expected behavior on platforms without TAM ST support. The SAI layer queries for TAM ST Stats capabilities, and unsupported platforms correctly return SAI_STATUS_NOT_SUPPORTED (error -2).
However, loganalyzer currently treats this as a test failure, resulting in false positives.
How did you do it?
Added a new ignore pattern to ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt at line 38:
r, ".* ERR syncd#syncd: [none] SAI_API_SWITCH:sai_query_stats_st_capability:\d+ Get TAM ST Stats capabilities failed with error -2.*"
How did you verify/test it?
pfcwd/test_pfcwd_cli.py::test_pfcwd_show_stat[IPv6-ld301] ERROR
pfcwd/test_pfcwd_cli.py::test_pfcwd_show_stat[IPv4-ld301] ERROR
Result: 2 passed, 2 errors in 2859.92s
With fix:
All tests pass without loganalyzer errors
Result: 2 passed, 0 errors in 2686.99s
Any platform specific information?
None
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A