[platform_tests] Skip warm reboot on non-T0 topologies by bingwang-ms · Pull Request #23133 · sonic-net/sonic-mgmt

bingwang-ms · 2026-03-19T09:29:35Z

Description of PR

Summary:
Update the platform test conditional-mark YAML so platform_tests/test_reboot.py::test_warm_reboot is also skipped on lt2 and ft2 topologies.

Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

platform_tests/test_reboot.py::test_warm_reboot already had a topology-based skip list in the platform test conditional-mark YAML. The requested change is to extend that existing list to cover lt2 and ft2 as well.

How did you do it?

updated tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml
kept the existing skip model in place
extended the topology list from ['m0', 'mx', 'm1', 't1', 't2'] to ['m0', 'mx', 'm1', 't1', 't2', 'lt2', 'ft2']
preserved the existing dualtor and HWSKU-specific guards

How did you verify/test it?

python -c "import pathlib, yaml; p=pathlib.Path(r'tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml'); yaml.safe_load(p.read_text()); print('yaml_ok')"
inspected the focused diff against upstream/master

Any platform specific information?

This is a collection-time conditional-mark change for platform tests. It extends the existing non-T0-style topology list for this specific warm reboot test to include lt2 and ft2.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

No documentation update is needed.

Signed-off-by: Bing Wang <[email protected]>

mssonicbld · 2026-03-19T09:29:44Z

/azp run

azure-pipelines · 2026-03-19T09:29:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Bing Wang <[email protected]>

mssonicbld · 2026-03-19T09:32:59Z

/azp run

azure-pipelines · 2026-03-19T09:33:14Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS · 2026-03-19T14:08:11Z

Code Review

✅ LGTM — Clean 2-line change extending the warm reboot topology skip list to include lt2 and ft2. Well-documented PR description with YAML validation.

StormLiangMS

LGTM

What is the motivation for this PR? platform_tests/test_reboot.py::test_warm_reboot already had a topology-based skip list in the platform test conditional-mark YAML. The requested change is to extend that existing list to cover lt2 and ft2 as well. How did you do it? updated tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml kept the existing skip model in place extended the topology list from ['m0', 'mx', 'm1', 't1', 't2'] to ['m0', 'mx', 'm1', 't1', 't2', 'lt2', 'ft2'] preserved the existing dualtor and HWSKU-specific guards How did you verify/test it? python -c "import pathlib, yaml; p=pathlib.Path(r'tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml'); yaml.safe_load(p.read_text()); print('yaml_ok')" inspected the focused diff against upstream/master Any platform specific information? This is a collection-time conditional-mark change for platform tests. It extends the existing non-T0-style topology list for this specific warm reboot test to include lt2 and ft2. Supported testbed topology if it's a new test case? Not a new test case. Documentation No documentation update is needed. Signed-off-by: Bing Wang <[email protected]> --------- Signed-off-by: Bing Wang <[email protected]> Signed-off-by: mssonicbld <[email protected]>

mssonicbld · 2026-03-19T14:26:36Z

Cherry-pick PR to 202511: #23139

What is the motivation for this PR? platform_tests/test_reboot.py::test_warm_reboot already had a topology-based skip list in the platform test conditional-mark YAML. The requested change is to extend that existing list to cover lt2 and ft2 as well. How did you do it? updated tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml kept the existing skip model in place extended the topology list from ['m0', 'mx', 'm1', 't1', 't2'] to ['m0', 'mx', 'm1', 't1', 't2', 'lt2', 'ft2'] preserved the existing dualtor and HWSKU-specific guards How did you verify/test it? python -c "import pathlib, yaml; p=pathlib.Path(r'tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml'); yaml.safe_load(p.read_text()); print('yaml_ok')" inspected the focused diff against upstream/master Any platform specific information? This is a collection-time conditional-mark change for platform tests. It extends the existing non-T0-style topology list for this specific warm reboot test to include lt2 and ft2. Supported testbed topology if it's a new test case? Not a new test case. Documentation No documentation update is needed. Signed-off-by: Bing Wang <[email protected]> --------- Signed-off-by: Bing Wang <[email protected]> Signed-off-by: mssonicbld <[email protected]>

What is the motivation for this PR? platform_tests/test_reboot.py::test_warm_reboot already had a topology-based skip list in the platform test conditional-mark YAML. The requested change is to extend that existing list to cover lt2 and ft2 as well. How did you do it? updated tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml kept the existing skip model in place extended the topology list from ['m0', 'mx', 'm1', 't1', 't2'] to ['m0', 'mx', 'm1', 't1', 't2', 'lt2', 'ft2'] preserved the existing dualtor and HWSKU-specific guards How did you verify/test it? python -c "import pathlib, yaml; p=pathlib.Path(r'tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml'); yaml.safe_load(p.read_text()); print('yaml_ok')" inspected the focused diff against upstream/master Any platform specific information? This is a collection-time conditional-mark change for platform tests. It extends the existing non-T0-style topology list for this specific warm reboot test to include lt2 and ft2. Supported testbed topology if it's a new test case? Not a new test case. Documentation No documentation update is needed. Signed-off-by: Bing Wang <[email protected]> --------- Signed-off-by: Bing Wang <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>

What is the motivation for this PR? platform_tests/test_reboot.py::test_warm_reboot already had a topology-based skip list in the platform test conditional-mark YAML. The requested change is to extend that existing list to cover lt2 and ft2 as well. How did you do it? updated tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml kept the existing skip model in place extended the topology list from ['m0', 'mx', 'm1', 't1', 't2'] to ['m0', 'mx', 'm1', 't1', 't2', 'lt2', 'ft2'] preserved the existing dualtor and HWSKU-specific guards How did you verify/test it? python -c "import pathlib, yaml; p=pathlib.Path(r'tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml'); yaml.safe_load(p.read_text()); print('yaml_ok')" inspected the focused diff against upstream/master Any platform specific information? This is a collection-time conditional-mark change for platform tests. It extends the existing non-T0-style topology list for this specific warm reboot test to include lt2 and ft2. Supported testbed topology if it's a new test case? Not a new test case. Documentation No documentation update is needed. Signed-off-by: Bing Wang <[email protected]> --------- Signed-off-by: Bing Wang <[email protected]>

[platform_tests] Skip warm reboot on non-T0 topologies

39cd5d0

Signed-off-by: Bing Wang <[email protected]>

github-actions bot requested review from BYGX-wcr, xwjiang-ms and yutongzhang-microsoft March 19, 2026 09:29

[platform_tests] Extend warm reboot skip topology list

fe2df52

Signed-off-by: Bing Wang <[email protected]>

Copilot AI mentioned this pull request Mar 19, 2026

Review human-authored PRs opened in the past 24 hours #23134

Draft

auspham approved these changes Mar 19, 2026

View reviewed changes

StormLiangMS approved these changes Mar 19, 2026

View reviewed changes

StormLiangMS merged commit 414c255 into sonic-net:master Mar 19, 2026
16 checks passed

StormLiangMS added Request for 202511 branch Request to backport a change to 202511 branch Approved for 202511 branch labels Mar 19, 2026

mssonicbld added the Created PR to 202511 branch label Mar 19, 2026

mssonicbld mentioned this pull request Mar 19, 2026

[action] [PR:23133] [platform_tests] Skip warm reboot on non-T0 topologies #23139

Merged

12 tasks

mssonicbld added Included in 202511 branch and removed Created PR to 202511 branch labels Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[platform_tests] Skip warm reboot on non-T0 topologies#23133

[platform_tests] Skip warm reboot on non-T0 topologies#23133
StormLiangMS merged 2 commits intosonic-net:masterfrom
bingwang-ms:warm-reboot-non-t0-skip

bingwang-ms commented Mar 19, 2026 •

edited

Loading

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

StormLiangMS commented Mar 19, 2026

Uh oh!

StormLiangMS left a comment

Uh oh!

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bingwang-ms commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

azure-pipelines bot commented Mar 19, 2026

Uh oh!

StormLiangMS commented Mar 19, 2026

Code Review

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bingwang-ms commented Mar 19, 2026 •

edited

Loading