[bgp] Support BGP confederation in update replication test#23131
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Mar 20, 2026
Merged
[bgp] Support BGP confederation in update replication test#23131bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Bing Wang <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
approved these changes
Mar 19, 2026
Collaborator
Code Review✅ LGTM — Correctly adds |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Bing Wang <[email protected]> Signed-off-by: mssonicbld <[email protected]>
Collaborator
|
Cherry-pick PR to 202511: #23150 |
12 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Bing Wang <[email protected]> Signed-off-by: mssonicbld <[email protected]>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
Signed-off-by: Bing Wang <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Bing Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Improve
tests/bgp/test_bgp_update_replication.pyso the test can establish ExaBGP neighbors correctly on BGP confederation topologies.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_bgp_update_replication.pycurrently brings up BGP peers by using onlyminigraph_bgp_asnas the DUT-facing ASN. That works for regular topologies, but it does not work correctly when the DUT is running BGP confederation.How did you do it?
get_bgp_confed_asn()confed_asninto eachBGPNeighboruse_vtyshforFabricSpineRouterwhen confederation is enabled, matching the existing confed-aware pattern already used by nearby BGP testsHow did you verify/test it?
python -m flake8 --max-line-length=120 tests\\bgp\\test_bgp_update_replication.pypython -m py_compile tests\\bgp\\test_bgp_update_replication.pypython -m pytest --collect-only tests\\bgp\\test_bgp_update_replication.py -q, but collection is blocked in this Windows environment because repo test helpers import Linux-onlyfcntlThe change is also validated on a physical testbed
Any platform specific information?
This change is only relevant for confederation-enabled topologies, especially FT2
FabricSpineRoutercases that require the existingvtyshconfiguration path.Supported testbed topology if it's a new test case?
Not a new test case.
Documentation
No documentation update is needed because this changes existing test setup logic only.