Skip to content

[ha] get remote npu pa ip (loopback0 ip) from topo definition instead of hard coding #23125

Merged
prsunny merged 1 commit intosonic-net:masterfrom
zjswhhh:loopback_public
Mar 23, 2026
Merged

[ha] get remote npu pa ip (loopback0 ip) from topo definition instead of hard coding #23125
prsunny merged 1 commit intosonic-net:masterfrom
zjswhhh:loopback_public

Conversation

@zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Mar 19, 2026

Description of PR

Summary:
Fixes # (issue)

Currently the remote npu pa ip is harded in the config, which doesn't match the loopback of remote npu's loopback. Submitting this PR to fix that.

sign-off: Jing Zhang [email protected]

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

To removed hard coded IP addresses.

How did you do it?

Get the remote npu's PA IP from tbinfo (topology file).

How did you verify/test it?

Ran ha test to trigger the configuring fixture. Confirmed the IP matches in config_db afterwards.

Any platform specific information?

NO.

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Jing Zhang <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zjswhhh zjswhhh marked this pull request as ready for review March 23, 2026 03:24
@zjswhhh zjswhhh requested a review from prsunny March 23, 2026 03:24
@zjswhhh
Copy link
Contributor Author

zjswhhh commented Mar 23, 2026

@nnelluri-cisco @aronovic - please help review

@zjswhhh zjswhhh added smartswitch-ha Label for tracking smartswitch HA related changes Request for 202511 branch Request to backport a change to 202511 branch labels Mar 23, 2026
Copy link
Contributor

@aronovic aronovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@prsunny prsunny merged commit 1fdba11 into sonic-net:master Mar 23, 2026
15 checks passed
@mssonicbld
Copy link
Collaborator

@zjswhhh PR conflicts with 202511 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved for 202511 branch Cherry Pick Conflict_202511 Request for 202511 branch Request to backport a change to 202511 branch smartswitch-ha Label for tracking smartswitch HA related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants