Add INCLUDE_JOBS for PR and baseline tests#23123
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Mar 20, 2026
Merged
Add INCLUDE_JOBS for PR and baseline tests#23123StormLiangMS merged 2 commits intosonic-net:masterfrom
StormLiangMS merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: xiaweijiang <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Code Review✅ LGTM — Clean addition of |
Signed-off-by: xiaweijiang <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
changed the title
Collaborator
|
@xwjiang-ms do we need cherrypick? |
8 tasks
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 23, 2026
Why I did it In PR sonic-net/sonic-mgmt#23123, I added INCLUDE_JOBS to allow PR test and baseline test in different scopes. So need corresponding change in baseline yaml Signed-off-by: xiaweijiang <[email protected]>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
What is the motivation for this PR? pr_test_template.yml is shared by PR test and baseline test. PR test should stay scoped to the default t0/t1/t2 jobs, but baseline test needs a way to run the full job set, including jobs such as multi-asic. How did you do it? Added INCLUDE_JOBS to pr_test_template.yml with default value t0_job,t1_job,t2_job. Updated each test job condition to check both: the existing impacted-area PR_CHECKERS result whether the job is enabled by INCLUDE_JOBS Updated baseline.test.mgmt.public.yml to pass INCLUDE_JOBS: all so baseline keeps running the full job set. Did not change get-impacted-area.yml. Signed-off-by: xiaweijiang <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
12 tasks
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? pr_test_template.yml is shared by PR test and baseline test. PR test should stay scoped to the default t0/t1/t2 jobs, but baseline test needs a way to run the full job set, including jobs such as multi-asic. How did you do it? Added INCLUDE_JOBS to pr_test_template.yml with default value t0_job,t1_job,t2_job. Updated each test job condition to check both: the existing impacted-area PR_CHECKERS result whether the job is enabled by INCLUDE_JOBS Updated baseline.test.mgmt.public.yml to pass INCLUDE_JOBS: all so baseline keeps running the full job set. Did not change get-impacted-area.yml. Signed-off-by: xiaweijiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Keep the shared PR test template limited to
t0,t1,t2by default, and allow baseline pipelines to override the topology scope to run all supported checkers.Type of change
Back port request
Approach
What is the motivation for this PR?
pr_test_template.ymlis shared by PR test and baseline test. PR test should stay scoped to the defaultt0/t1/t2jobs, but baseline test needs a way to run the full job set, including jobs such as multi-asic.How did you do it?
Added
INCLUDE_JOBStopr_test_template.ymlwith default valuet0_job,t1_job,t2_job.Updated each test job condition to check both:
PR_CHECKERSresultINCLUDE_JOBSUpdated
baseline.test.mgmt.public.ymlto passINCLUDE_JOBS: allso baseline keeps running the full job set.Did not change
get-impacted-area.yml.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation