[smartswitch] Remove acms from smartswitch DPU config#23111
Merged
prsunny merged 1 commit intosonic-net:masterfrom Mar 24, 2026
Merged
[smartswitch] Remove acms from smartswitch DPU config#23111prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
Removing the acms entry allows the feature's default state to apply. Signed-off-by: Vasundhara Volam <vvolam@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
approved these changes
Mar 19, 2026
Collaborator
Code Review✅ LGTM — Straightforward 3-line removal of the hardcoded |
Collaborator
|
@vvolam could you follow this template for the description part of PR? https://github.com/sonic-net/sonic-mgmt/blob/master/.github/PULL_REQUEST_TEMPLATE.md |
Contributor
Author
Updated! Thank you @StormLiangMS . I have created a PR to update copilot instructions as well #23142, to avoid the mistake in future |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 24, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #23227 |
8 tasks
mssonicbld
added a commit
that referenced
this pull request
Mar 24, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Co-authored-by: Vasundhara Volam <163894573+vvolam@users.noreply.github.com>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Remove the hardcoded
"acms": {"state": "disabled"}entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows theacmsfeature's default state to apply naturally, rather than forcing it to disabled via the golden config.Type of change
Back port request
Approach
What is the motivation for this PR?
The golden config was explicitly disabling
acmson DPUs. This is not needed — the feature should use its default state. Keeping this explicitdisabledentry can mask issues and preventsacmsfrom starting even when it should.How did you do it?
Removed the 3-line
"acms": {"state": "disabled"}block fromansible/golden_config_db/smartswitch_dpu_extra.json.How did you verify/test it?
Verified on a smartswitch testbed that the DPU comes up correctly and that the
acmsfeature uses its default state after the golden config is applied.Any platform specific information?
Applies to smartswitch platforms using the DPU golden config.
Supported testbed topology if it's a new test case?
N/A — not a new test case.
Documentation
N/A
Signed-off-by: Vasundhara Volam vvolam@microsoft.com