Skip to content

[smartswitch] Remove acms from smartswitch DPU config#23111

Merged
prsunny merged 1 commit intosonic-net:masterfrom
vvolam:fix-dpu-acms
Mar 24, 2026
Merged

[smartswitch] Remove acms from smartswitch DPU config#23111
prsunny merged 1 commit intosonic-net:masterfrom
vvolam:fix-dpu-acms

Conversation

@vvolam
Copy link
Contributor

@vvolam vvolam commented Mar 19, 2026

Description of PR

Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.

Type of change

  • Bug fix

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

The golden config was explicitly disabling acms on DPUs. This is not needed — the feature should use its default state. Keeping this explicit disabled entry can mask issues and prevents acms from starting even when it should.

How did you do it?

Removed the 3-line "acms": {"state": "disabled"} block from ansible/golden_config_db/smartswitch_dpu_extra.json.

How did you verify/test it?

Verified on a smartswitch testbed that the DPU comes up correctly and that the acms feature uses its default state after the golden config is applied.

Any platform specific information?

Applies to smartswitch platforms using the DPU golden config.

Supported testbed topology if it's a new test case?

N/A — not a new test case.

Documentation

N/A

Signed-off-by: Vasundhara Volam vvolam@microsoft.com

Removing the acms entry allows the feature's default state to apply.

Signed-off-by: Vasundhara Volam <vvolam@microsoft.com>
@github-actions github-actions bot requested review from r12f, sdszhang and wangxin March 19, 2026 01:38
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam vvolam added the Request for 202511 branch Request to backport a change to 202511 branch label Mar 19, 2026
@StormLiangMS
Copy link
Collaborator

Code Review

LGTM — Straightforward 3-line removal of the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config, allowing the feature's default state to apply naturally.

@StormLiangMS
Copy link
Collaborator

@vvolam could you follow this template for the description part of PR? https://github.com/sonic-net/sonic-mgmt/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@vvolam
Copy link
Contributor Author

vvolam commented Mar 19, 2026

@vvolam could you follow this template for the description part of PR? https://github.com/sonic-net/sonic-mgmt/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Updated! Thank you @StormLiangMS . I have created a PR to update copilot instructions as well #23142, to avoid the mistake in future

@prsunny prsunny merged commit fd971fa into sonic-net:master Mar 24, 2026
18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 24, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.

Signed-off-by: mssonicbld <sonicbld@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #23227

mssonicbld added a commit that referenced this pull request Mar 24, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.

Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Co-authored-by: Vasundhara Volam <163894573+vvolam@users.noreply.github.com>
ravaliyel pushed a commit to ravaliyel/sonic-mgmt that referenced this pull request Mar 27, 2026
Summary:
Remove the hardcoded "acms": {"state": "disabled"} entry from the smartswitch DPU golden config (ansible/golden_config_db/smartswitch_dpu_extra.json). Removing this entry allows the acms feature's default state to apply naturally, rather than forcing it to disabled via the golden config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants