Skip to content

[pytest] Test the running status of Monit service #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxin merged 11 commits into from
Oct 10, 2020
Merged

[pytest] Test the running status of Monit service #2309

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2e16676
[pytest] Test the running status of Monit service.
yozhao101 Oct 5, 2020
ed8c8e3
[pytest] Except the 'running' and 'failed' states, Monit will be in
yozhao101 Oct 8, 2020
5a6e823
[pytest] Use an 'else' statement to cover all other cases in which Monit
yozhao101 Oct 8, 2020
a4021ed
[pytest] Use 'Monit Service is not running' in the message.
yozhao101 Oct 8, 2020
cc6c755
[pytest] Show possible reasons in the message why Monit service is no…
yozhao101 Oct 8, 2020
5609843
[pytest] Append the status line of Monit service to the output if it …
yozhao101 Oct 8, 2020
36c56cb
[pytest] Change the folder name from monit_test to monit.
yozhao101 Oct 9, 2020
7b233be
[pytest] Use the return code of commnad `sudo monit status` to
yozhao101 Oct 10, 2020
5b9857e
[pytest] Fix a typo.
yozhao101 Oct 10, 2020
686a13a
[pytest] Change the variable names and delete the comment of this
yozhao101 Oct 10, 2020
8a199ba
[pytest] Change the file name of pytest script.
yozhao101 Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions tests/monit/test_monit_service_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
"""
Test the running status of Monit service
"""
import logging

import pytest

logger = logging.getLogger(__name__)

pytestmark = [
pytest.mark.topology('any')
]


def test_monit_service_status(duthost):
Copy link
Copy Markdown
Contributor

@jleveque jleveque Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest shortening the name of this function and the file to test_monit_status

"""
@summary: Test the running status of Monit service by analyzing the command
output of "sudo systemctl status monit.service | grep Active".
Copy link
Copy Markdown
Contributor

@jleveque jleveque Oct 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summary is now out of date and references the wrong command. Suggest removing the command from it altogether, as the command is two lines below and the function is simple.

"""
monit_service_status_info = duthost.shell("sudo monit status", module_ignore_errors=True)
Copy link
Copy Markdown
Contributor

@jleveque jleveque Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming var to monit_status_result


exit_code = monit_service_status_info["rc"]
if exit_code == 0:
logger.info("Monit service is running.")
else:
pytest.fail("Monit service is not running.")