Skip to content

[sanity-check]: Fix UnboundLocalError when post-check fails #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theasianpianist merged 1 commit into from
Oct 1, 2020
Merged

[sanity-check]: Fix UnboundLocalError when post-check fails #2304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/common/plugins/sanity_check/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def sanity_check(localhost, duthost, request, fanouthosts, tbinfo):
logger.info("!!!!!!!!!!!!!!!! Post-test sanity check results: !!!!!!!!!!!!!!!!\n%s" % \
json.dumps(post_check_results, indent=4))
if any([result["failed"] for result in post_check_results]):
failed_items = json.dumps([result for result in new_check_results if result["failed"]], indent=4)
failed_items = json.dumps([result for result in post_check_results if result["failed"]], indent=4)
logger.error("Failed check items:\n{}".format(failed_items))
pytest.fail("Post-test sanity check failed with failed items:\n{}".format(failed_items))
return
Expand Down