[action] [PR:22871] ignore ingress drop caused by non-unicast noise#22934
Merged
mssonicbld merged 1 commit intosonic-net:202511from Mar 13, 2026
Merged
[action] [PR:22871] ignore ingress drop caused by non-unicast noise#22934mssonicbld merged 1 commit intosonic-net:202511from
mssonicbld merged 1 commit intosonic-net:202511from
Conversation
more and more qos test break by environment noise: unexpected non-unicast traffic caused ingress drop. This PR adds a helper function to detect and ignore ingress drops caused by broadcast/multicast noise, preventing unnecessary test failures. Signed-off-by: Xu Chen <[email protected]> Signed-off-by: mssonicbld <[email protected]>
12 tasks
Collaborator
Author
|
Original PR: #22871 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
More and more QoS tests break by environment noise: unexpected non-unicast traffic caused ingress drop counters to increase, leading to false positive test failures.
This PR adds a helper function
ignore_ingress_drop_caused_by_nonunicast_noiseto detect and ignore ingress drops caused by broadcast/multicast noise, preventing unnecessary test failures.Type of change
Back port request
Approach
What is the motivation for this PR?
Non-unicast environmental noise (broadcast/multicast traffic) causes unexpected ingress drop counter increases on DUT receive ports. This leads to false positive failures in PFC/QoS SAI tests (PFCXonTest, PFCtest, etc.), even when the DUT behavior is correct.
How did you do it?
ignore_ingress_drop_caused_by_nonunicast_noise()function that checks if ingress drop increase correlates with non-unicast packet counter increase on the same portHow did you verify/test it?
Verified on internal testbed via ADO PR #18719 (approved by Storm Liang and Austin Pham). The change was tested on chassis topology with Cisco-8000 platform.
Any platform specific information?
Counter margin (COUNTER_MARGIN) is applied for broadcom-dnx, cisco-8000, and marvell-teralynx platforms due to known extra IPv6 NS/RA packets from VM.
Supported testbed topology if it's a new test case?
N/A - this is a bug fix to existing test cases.
Documentation
N/A