Skip to content

[test_advanced_reboot] Add missing import for get_advanced_reboot#2286

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_test_advanced_reboot
Sep 29, 2020
Merged

[test_advanced_reboot] Add missing import for get_advanced_reboot#2286
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_test_advanced_reboot

Conversation

@bingwang-ms
Copy link
Collaborator

@bingwang-ms bingwang-ms commented Sep 29, 2020

Description of PR

Summary:
Fixes # (issue)
Recent PR #2239 removed import for get_advanced_reboot, which caused test regression in test_advanced_reboot.

E       fixture 'get_advanced_reboot' not found
>       available fixtures: __pytest_repeat_step_number, ansible_adhoc, ansible_facts, ansible_module, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, change_mac_addresses, check_dut_asic_type, collect_techsupport, config_logging, conn_graph_facts, copy_ptftests_directory, creds, disable_container_autorestart, doctest_namespace, duthost, duthosts, enhance_inventory, eos, fanouthosts, fib, localhost, loganalyzer, metadata, minigraph_facts, monkeypatch, nbrhosts, pdu, psu_controller, ptfadapter, ptfhost, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, reset_critical_services_list, sanity_check, scaled_vnet_params, skip_on_simx, tag_test_report, tbinfo, test_tacacs, test_tacacs_v6, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, vnet_config, vnet_test_params, worker_id

This PR is to address the issue.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to fix regression caused by #2239

How did you do it?

Add import for get_advanced_reboot

How did you verify/test it?

Verified on Arista-7260

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --topology=t0,any,util platform_tests/test_advanced_reboot.py::test_warm_reboot
========================================================================================= test session starts =========================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
metadata: {'Python': '2.7.12', 'Platform': 'Linux-4.10.0-42-generic-x86_64-with-Ubuntu-16.04-xenial', 'Packages': {'py': '1.9.0', 'pytest': '4.6.5', 'pluggy': '0.13.1'}, 'Plugins': {u'repeat': u'0.8.0', u'html': u'1.22.1', u'xdist': u'1.28.0', u'ansible': u'2.2.2', u'forked': u'1.3.0', u'metadata': u'1.10.0'}}
ansible: 2.8.12
rootdir: /data/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, forked-1.3.0, xdist-1.28.0, html-1.22.1, repeat-0.8.0, metadata-1.10.0
collected 1 item                                                                                                                                                                                      

platform_tests/test_advanced_reboot.py::test_warm_reboot ^@^@PASSED                                                                                                                                 [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
===================================================================================== 1 passed in 799.42 seconds ======================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

No.

@bingwang-ms bingwang-ms requested a review from a team September 29, 2020 07:21
@bingwang-ms bingwang-ms merged commit e0ab626 into sonic-net:master Sep 29, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
swss:
* 7841930 2022-07-15 | [vxlan]Fixing L2MC vlan member caching issue (sonic-net#2378) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam]
* b8cd435 2022-07-14 | [muxorch] Always use direct link for SoC IPs (sonic-net#2369) [Longxiang Lyu]
* 6158d5c 2022-07-08 | Add BGP profile to Vnet routes (sonic-net#2337) [Prince Sunny]
* bdb7ffd 2022-07-06 | [teammgr]: Waiting MACsec ready before doLagMemberTask (sonic-net#2286) [Ze Gan]

sairedis:
* 58359d4 2022-06-30 | [sairedis] Perform log rotate on request (sonic-net#1058) (HEAD -> 202205, github/202205) [Kamil Cudnik]
* cad0268 2022-07-13 | Enable cisco debug shell by default (sonic-net#1078) [VenkatCisco]

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants