[snappi] Fixed typo in variable hostname in variables.override.yml file to resolve key-error#22570
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 25, 2026
Conversation
Signed-off-by: amitpawa <[email protected]>
github-actions
bot
requested review from
auspham,
deepak-singhal0408 and
rraghav-cisco
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Feb 24, 2026
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…onic-net#22570) Description of PR The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code: for port in snappi_port_list: for var_rx_port in var_rx_ports: if port['peer_port'] == var_rx_port['port_name'] and port['peer_device'] == var_rx_port['hostname']: rx_snappi_ports.append(port) for var_tx_port in var_tx_ports: if port['peer_port'] == var_tx_port['port_name'] and port['peer_device'] == var_tx_port['hostname']: tx_snappi_ports.append(port) Summary: Fixes sonic-net#22360 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fixed a minor typo error. How did you do it? Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file. How did you verify/test it? Ran it on local branch with fixed parameter. Signed-off-by: amitpawa <[email protected]> Signed-off-by: Mihut Aronovici <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…onic-net#22570) Description of PR The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code: for port in snappi_port_list: for var_rx_port in var_rx_ports: if port['peer_port'] == var_rx_port['port_name'] and port['peer_device'] == var_rx_port['hostname']: rx_snappi_ports.append(port) for var_tx_port in var_tx_ports: if port['peer_port'] == var_tx_port['port_name'] and port['peer_device'] == var_tx_port['hostname']: tx_snappi_ports.append(port) Summary: Fixes sonic-net#22360 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fixed a minor typo error. How did you do it? Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file. How did you verify/test it? Ran it on local branch with fixed parameter. Signed-off-by: amitpawa <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…utomatically (sonic-net#22570) #### Why I did it src/sonic-host-services ``` * 9082af7 - (HEAD -> 202405, origin/202405) [kdump-config] update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (cherry-pick from master to 202405) (sonic-net#236) (4 days ago) [Marty Y. Lok] ``` #### How I did it #### How to verify it #### Description for the changelog
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…onic-net#22570) Description of PR The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code: for port in snappi_port_list: for var_rx_port in var_rx_ports: if port['peer_port'] == var_rx_port['port_name'] and port['peer_device'] == var_rx_port['hostname']: rx_snappi_ports.append(port) for var_tx_port in var_tx_ports: if port['peer_port'] == var_tx_port['port_name'] and port['peer_device'] == var_tx_port['hostname']: tx_snappi_ports.append(port) Summary: Fixes sonic-net#22360 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fixed a minor typo error. How did you do it? Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file. How did you verify/test it? Ran it on local branch with fixed parameter. Signed-off-by: amitpawa <[email protected]> Signed-off-by: Abhishek <[email protected]>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…onic-net#22570) Description of PR The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code: for port in snappi_port_list: for var_rx_port in var_rx_ports: if port['peer_port'] == var_rx_port['port_name'] and port['peer_device'] == var_rx_port['hostname']: rx_snappi_ports.append(port) for var_tx_port in var_tx_ports: if port['peer_port'] == var_tx_port['port_name'] and port['peer_device'] == var_tx_port['hostname']: tx_snappi_ports.append(port) Summary: Fixes sonic-net#22360 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fixed a minor typo error. How did you do it? Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file. How did you verify/test it? Ran it on local branch with fixed parameter. Signed-off-by: amitpawa <[email protected]> Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…onic-net#22570) Description of PR The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code: for port in snappi_port_list: for var_rx_port in var_rx_ports: if port['peer_port'] == var_rx_port['port_name'] and port['peer_device'] == var_rx_port['hostname']: rx_snappi_ports.append(port) for var_tx_port in var_tx_ports: if port['peer_port'] == var_tx_port['port_name'] and port['peer_device'] == var_tx_port['hostname']: tx_snappi_ports.append(port) Summary: Fixes sonic-net#22360 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fixed a minor typo error. How did you do it? Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file. How did you verify/test it? Ran it on local branch with fixed parameter. Signed-off-by: amitpawa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The parameter "hostname" in variables.override.yml is defined as "host_name". This causes key-error in function get_snappi_ports_for_rdma present in snappi_fixtures.py in the following code:
Summary:
Fixes #22360
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixed a minor typo error.
How did you do it?
Fixed a minor typo error. Corrected the variable 'host_name" to "hostname" in the yml file.
How did you verify/test it?
Ran it on local branch with fixed parameter.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation