[ci] Fix semgrep issues with inline nosemgrep comments#22512
Merged
Conversation
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Replace .semgrepignore with targeted inline # nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. Fixes line-length violations from nosemgrep comments by moving comments to preceding lines or reformatting. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
rustiqly
force-pushed
the
fix/semgrep-nosemgrep-inline
branch
from
e29048b to
decba53
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Why did we need a new PR? Keeping the original PR keeps all the discussion about an issue in one place. I do prefer the individual no-semgrep rather than blanket ignoring for files though, thanks! |
yxieca
approved these changes
Feb 24, 2026
yxieca
left a comment
yxieca
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed: nosemgrep annotations only; looks good.
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Apr 1, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Apr 3, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 11, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 11, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 11, 2026
What is the motivation for this PR Replace .semgrepignore with targeted inline nosemgrep comments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression. How did you do it Added inline nosemgrep annotations to 15 files and reformatted to keep lines within 120 chars. No functional code changes. How did you verify/test it Not provided in PR description. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace .semgrepignore with targeted inline
# nosemgrepcomments for 28 legacy infrastructure files (ansible, spytest). This addresses the semgrep findings without blanket directory-level suppression.Fixes line-length violations (E501) from nosemgrep comments by moving comments to preceding lines or reformatting.
Takes over from #22463 per team decision.
Changes:
# nosemgrep: <rule-id>comments