-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Test Framework Support for IPv6-only Management Network #22407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b2cc2f2
Add IPv6-only management network support for virtual testbed
opcoder0 f677006
Remove root dependency for chrony docker container
opcoder0 7a0c02b
Specify non root USER before running command
opcoder0 8ae0786
Fix pipeline parameter
opcoder0 c1fec13
undo group_vars change
opcoder0 87a167d
undo veos_vtb change
opcoder0 a10095e
Merge branch 'master' into feature/ipv6-only-mgmt
opcoder0 e03c2bc
Pretest and sanity check changes for IPv6 only mgmt setup
opcoder0 9801318
Remove use of environment variable and use fixture and global variabl…
opcoder0 ac11d8a
Merge branch 'master' into ipv6-only-mgmt-test-setup
opcoder0 94674ce
Update documentation
opcoder0 2f72bf7
Remove pr_test_template changes
opcoder0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -769,7 +769,9 @@ def ssh_connection_with_retry(localhost, host_ip, port, delay, timeout): | |
|
|
||
| def collect_mgmt_config_by_console(duthost, localhost): | ||
| logger.info("check if dut is pingable") | ||
| localhost.shell(f"ping -c 5 {duthost.mgmt_ip}", module_ignore_errors=True) | ||
| # Use ping6 for IPv6 addresses, ping for IPv4 | ||
| ping_cmd = "ping6" if ":" in str(duthost.mgmt_ip) else "ping" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is better to use |
||
| localhost.shell(f"{ping_cmd} -c 5 {duthost.mgmt_ip}", module_ignore_errors=True) | ||
|
|
||
| logger.info("Start: collect mgmt config by console") | ||
| creds = creds_on_dut(duthost) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid using global variable?