[action] [PR:21947] Fix Issue with Checking for Active ACL Rules by aclshow -a#22226
Merged
vmittal-msft merged 1 commit intosonic-net:202511from Feb 3, 2026
Merged
Conversation
…et#21947) * Feature/route programming data (sonic-net#21523) This PR adds test cases and supporting utilities to measure route programming time under high‑scale BGP IPv6 scenarios, building on the refactoring in PR sonic-net#21335. It focuses on quantifying how long it takes for routes to be fully programmed after BGP/connection events (e.g., convergence, admin flaps), and verifying that the measured RP times stay within expected limits and similar to the convergence time. Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>
5 tasks
Collaborator
Author
|
Original PR: #21947 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-mgmt |
Collaborator
Author
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Feb 3, 2026
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Feb 11, 2026
…et#21947) (sonic-net#22226) * Feature/route programming data (sonic-net#21523) This PR adds test cases and supporting utilities to measure route programming time under high‑scale BGP IPv6 scenarios, building on the refactoring in PR sonic-net#21335. It focuses on quantifying how long it takes for routes to be fully programmed after BGP/connection events (e.g., convergence, admin flaps), and verifying that the measured RP times stay within expected limits and similar to the convergence time. Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com> Co-authored-by: Andoni Sanguesa <31708881+AndoniSanguesa@users.noreply.github.com> Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some platforms appear to treat everflow ACLs differently from typical dataplane ACLs, in that counters in
showacl -awill always appear as N/A before and after traffic even if the rules are correctly formed. The previous version of the IPv6 Everflow test used the results ofshowacl -ato determine whether ACLs were configured and ready, but in the case of some Arista devices, the N/A behaviour caused the test to fail at that check. This PR simply changes the logic to check that all rules are 'active' in `show acl rule'.Type of change
Approach
What is the motivation for this PR?
We saw unexpected test failures after the deployment of the previous test
How did you do it?
Updated the failing check to use a source of truth that was reliable across platforms
How did you verify/test it?
Ran it against the known working platforms (sn4600) and verified it against platforms known to have the N/A issue (Arista 7060x6 and 7050cx3).
Documentation
acl_counters_fix_7060x6.txt
acl_counters_fix_sn2700.txt