Pass in multi ASIC flag correctly to test_everflow_fwd_recircle_port_queue_check#22224
Merged
saravanan-nexthop merged 2 commits intosonic-net:masterfrom Mar 21, 2026
Conversation
…queue_check Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
venu-nexthop
added a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Feb 9, 2026
Signed-off-by: venu-nexthop <venu@nexthop.ai>
12 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saravanan-nexthop
added
the
Request for 202511 branch
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…queue_check (sonic-net#22224) Signed-off-by: venu-nexthop <venu@nexthop.ai> Wrongly setting multiple namespace flag (applicable only to multi ASIC switches) is causing packets to be not sent out the ports and is causing queue counters not matching the expected number for T2 duts. See test_everflow_testbed.py: test_everflow_fwd_recircle_port_queue_check everflow_utils.verify_mirror_packets_on_recircle_port( self, ptfadapter, setup_info, setup_mirror_session, everflow_dut, rx_port_ptf_id, [tx_port_ptf_id], dest_port_type, queue, asic_ns, recircle_port, erspan_ip_ver, valid_across_namespace=everflow_dut.is_multi_asic, ) This call should pass in valid_across_namespace depending on everflow_dut.is_multi_asic value Otherwise valid_across_namespace is always set as True and is causing test failures Summary: Fixes # (issue) sonic-net#22223 Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
Collaborator
|
@venu-nexthop PR conflicts with 202511 branch |
12 tasks
venu-nexthop
added a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 25, 2026
Signed-off-by: venu-nexthop <venu@nexthop.ai>
12 tasks
venu-nexthop
added a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 25, 2026
Signed-off-by: venu-nexthop <venu@nexthop.ai>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 26, 2026
* Strict priority QOS test. (#21051) * Strict priority QOS test. Signed-off-by: Abhishek <abhishek@nexthop.ai> * Add q3d and portchannel support for strict priority. Signed-off-by: Abhishek <abhishek@nexthop.ai> * Fix per-commit and missing function. Signed-off-by: Abhishek <abhishek@nexthop.ai> --------- Signed-off-by: Abhishek <abhishek@nexthop.ai> * [backport][202511] reliable tsa tests are now skipped on single asic voq duts reliable tsa tests require two duthosts: one as supe and one as LC single asic voq dut have only one duthost, hence reliable tsa tests are skipped backporting #22089 Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai> * Revert "Strict priority QOS test. (#21051)" This reverts commit 88c7897. Signed-off-by: venu-nexthop <venu@nexthop.ai> * Revert "[backport][202511] reliable tsa tests are now skipped on single asic voq duts" This reverts commit 66748e6. Signed-off-by: venu-nexthop <venu@nexthop.ai> * Back porting #22224 to 202511 Signed-off-by: venu-nexthop <venu@nexthop.ai> --------- Signed-off-by: Abhishek <abhishek@nexthop.ai> Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai> Signed-off-by: venu-nexthop <venu@nexthop.ai> Co-authored-by: abhishek-nexthop <abhishek@nexthop.ai> Co-authored-by: saravanan sellappa <saravanan@nexthop.ai>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…queue_check (sonic-net#22224) Signed-off-by: venu-nexthop <venu@nexthop.ai> Wrongly setting multiple namespace flag (applicable only to multi ASIC switches) is causing packets to be not sent out the ports and is causing queue counters not matching the expected number for T2 duts. See test_everflow_testbed.py: test_everflow_fwd_recircle_port_queue_check everflow_utils.verify_mirror_packets_on_recircle_port( self, ptfadapter, setup_info, setup_mirror_session, everflow_dut, rx_port_ptf_id, [tx_port_ptf_id], dest_port_type, queue, asic_ns, recircle_port, erspan_ip_ver, valid_across_namespace=everflow_dut.is_multi_asic, ) This call should pass in valid_across_namespace depending on everflow_dut.is_multi_asic value Otherwise valid_across_namespace is always set as True and is causing test failures Summary: Fixes # (issue) sonic-net#22223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Wrongly setting multiple namespace flag (applicable only to multi ASIC switches) is causing
packets to be not sent out the ports and is causing queue counters not matching the expected number for T2 duts.
See test_everflow_testbed.py: test_everflow_fwd_recircle_port_queue_check
everflow_utils.verify_mirror_packets_on_recircle_port(
self,
ptfadapter,
setup_info,
setup_mirror_session,
everflow_dut,
rx_port_ptf_id,
[tx_port_ptf_id],
dest_port_type,
queue,
asic_ns,
recircle_port,
erspan_ip_ver,
valid_across_namespace=everflow_dut.is_multi_asic,
)
This call should pass in valid_across_namespace depending on everflow_dut.is_multi_asic value
Otherwise valid_across_namespace is always set as True and is causing test failures
Summary:
Fixes # (issue)
#22223
Type of change
Back port request
Approach
What is the motivation for this PR?
test_everflow_testbed.py: test_everflow_fwd_recircle_port_queue_check failing on T2 topo
How did you do it?
Passing in correct value of multi ASIC into the test function
How did you verify/test it?
Test passes with this fix
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation