Skip to content

[action] [PR:21939] Fix/nonlinear high nexthop dataplane downtime #22204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmittal-msft merged 1 commit into from
Feb 2, 2026
Merged

[action] [PR:21939] Fix/nonlinear high nexthop dataplane downtime #22204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions tests/bgp/test_ipv6_bgp_scale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,8 +633,8 @@ def test_nexthop_group_member_scale(
localhost,
tbinfo,
bgp_peers_info,
clean_ptf_dataplane,
setup_routes_before_test,
topo_bgp_routes,
request
):
'''
Expand All @@ -658,6 +658,7 @@ def test_nexthop_group_member_scale(
global global_icmp_type
global_icmp_type += 1
pdp = ptfadapter.dataplane
pdp.clear_masks()
pdp.set_qlen(PACKET_QUEUE_LENGTH)
exp_mask = setup_packet_mask_counters(pdp, global_icmp_type)
injection_bgp_neighbor = random.choice(list(bgp_peers_info.keys()))
Expand Down Expand Up @@ -729,34 +730,28 @@ def test_nexthop_group_member_scale(
terminated.set()
traffic_thread.join()
end_time = datetime.datetime.now()
validate_rx_tx_counters(pdp, end_time, start_time, exp_mask, _get_max_time('dataplane_downtime', 1))
acceptable_downtime = validate_rx_tx_counters(pdp, end_time, start_time, exp_mask,
_get_max_time('dataplane_downtime', 1))
if not acceptable_downtime:
for ptfhost in ptfhosts:
ptf_ip = ptfhost.mgmt_ip
announce_routes(localhost, tbinfo, ptf_ip, servers_dut_interfaces.get(ptf_ip, ''))
pytest.fail(f"Dataplane downtime is too high, threshold is "
f"{_get_max_time('dataplane_downtime', 1)} seconds")
if not result.get("converged"):
pytest.fail("BGP routes are not stable in long time")
finally:
for ptfhost in ptfhosts:
ptf_ip = ptfhost.mgmt_ip
change_routes_on_peers(localhost, ptf_ip, topo_name, peers_routes_to_change, ACTION_ANNOUNCE,
servers_dut_interfaces.get(ptf_ip, ''))
pass
# ------------announce routes and test ------------ #
current_test = request.node.name + "_announce"
global_icmp_type += 1
pdp.clear_masks()
exp_mask = setup_packet_mask_counters(pdp, global_icmp_type)
pkts = generate_packets(
neighbor_ecmp_routes[injection_bgp_neighbor],
duthost.facts['router_mac'],
pdp.get_mac(pdp.port_to_device(injection_port), injection_port)
)
for hostname, routes in peers_routes_to_change.items():
for route in routes:
prefix = route[0].upper()
found = False
for topo_route in topo_bgp_routes[hostname]['ipv6']:
if topo_route[0] == prefix:
route[2] = topo_route[2]
found = True
break
if not found:
logger.warning('Fail to update AS path of route %s, because of prefix was not found in topo', route[0])
terminated = Event()
traffic_thread = Thread(
target=send_packets, args=(terminated, pdp, pdp.port_to_device(injection_port), injection_port, pkts)
Expand All @@ -766,8 +761,7 @@ def test_nexthop_group_member_scale(
traffic_thread.start()
for ptfhost in ptfhosts:
ptf_ip = ptfhost.mgmt_ip
change_routes_on_peers(localhost, ptf_ip, topo_name, peers_routes_to_change, ACTION_ANNOUNCE,
servers_dut_interfaces.get(ptf_ip, ''))
announce_routes(localhost, tbinfo, ptf_ip, servers_dut_interfaces.get(ptf_ip, ''))
compressed_startup_routes = compress_expected_routes(startup_routes)
result = check_bgp_routes_converged(
duthost=duthost,
Expand All @@ -782,6 +776,9 @@ def test_nexthop_group_member_scale(
terminated.set()
traffic_thread.join()
end_time = datetime.datetime.now()
validate_rx_tx_counters(pdp, end_time, start_time, exp_mask, _get_max_time('dataplane_downtime', 1))
acceptable_downtime = validate_rx_tx_counters(pdp, end_time, start_time, exp_mask,
_get_max_time('dataplane_downtime', 1))
if not acceptable_downtime:
pytest.fail(f"Dataplane downtime is too high, threshold is {_get_max_time('dataplane_downtime', 1)} seconds")
if not result.get("converged"):
pytest.fail("BGP routes are not stable in long time")
Loading