Skip to content

Validate ACL rules and routes in test_everflow_testbed before traffic tests#22199

Merged
saravanan-nexthop merged 10 commits intosonic-net:masterfrom
nexthop-ai:venu-everflow-acl-validation-1
Mar 27, 2026
Merged

Validate ACL rules and routes in test_everflow_testbed before traffic tests#22199
saravanan-nexthop merged 10 commits intosonic-net:masterfrom
nexthop-ai:venu-everflow-acl-validation-1

Conversation

@venu-nexthop
Copy link
Copy Markdown
Contributor

Description of PR

Some of the test cases in test_everflow_testbed are failing because there is no
proper verification that the mirror ACL rules are created before traffic verification.
ACL rules are setup once at the beginning so wait_until for ACL rules only once at the beginning of the test.
Summary:
Fixes # (issue)
#22198

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

To fix everflow testbed test cases failures

How did you do it?

Added verification functions before proceeding with the traffic verification

How did you verify/test it?

everflow testbed test cases passing with the fix.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@venu-nexthop venu-nexthop marked this pull request as ready for review February 2, 2026 22:31
Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…-net#23329)

Why I did it
A number of dbg/dbsym packages are missing from the rules files and the relevant containers, therefore debugging is harder.

By adding these missing packages to the rules files, they get copied to the target/ directory and installed into the debug containers.

Work item tracking
Microsoft ADO (number only): 30052188
How I did it
Found all dbg/dbgsym debs below src/ that weren't copied to target/ and created rules to copy them

How to verify it
Build the image and the dbg/dbgsym packages will be included in the debug containers.
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: venu-nexthop <venu@nexthop.ai>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@YatishSVC
Copy link
Copy Markdown
Contributor

Hi @venu-nexthop, Are all the comments addressed?

@venu-nexthop
Copy link
Copy Markdown
Contributor Author

Hi @venu-nexthop, Are all the comments addressed?

Yes @YatishSVC

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@saravanan-nexthop
Copy link
Copy Markdown
Contributor

/azp run

@YatishSVC
Copy link
Copy Markdown
Contributor

@arista-nwolfe, are we okay to merge this?

@arista-nwolfe
Copy link
Copy Markdown
Contributor

@arista-nwolfe, are we okay to merge this?

Yeah I think this is good to merge

@saravanan-nexthop saravanan-nexthop merged commit 165627f into sonic-net:master Mar 27, 2026
18 of 19 checks passed
@saravanan-nexthop saravanan-nexthop deleted the venu-everflow-acl-validation-1 branch March 27, 2026 18:12
@saravanan-nexthop saravanan-nexthop added the Request for 202511 branch Request to backport a change to 202511 branch label Mar 27, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

@venu-nexthop PR conflicts with 202511 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants