Validate ACL rules and routes in test_everflow_testbed before traffic tests#22199
Merged
saravanan-nexthop merged 10 commits intosonic-net:masterfrom Mar 27, 2026
Merged
Conversation
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…-net#23329) Why I did it A number of dbg/dbsym packages are missing from the rules files and the relevant containers, therefore debugging is harder. By adding these missing packages to the rules files, they get copied to the target/ directory and installed into the debug containers. Work item tracking Microsoft ADO (number only): 30052188 How I did it Found all dbg/dbgsym debs below src/ that weren't copied to target/ and created rules to copy them How to verify it Build the image and the dbg/dbgsym packages will be included in the debug containers.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @venu-nexthop, Are all the comments addressed? |
Contributor
Author
Yes @YatishSVC |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
YatishSVC
approved these changes
Mar 27, 2026
Contributor
|
@arista-nwolfe, are we okay to merge this? |
Contributor
Yeah I think this is good to merge |
arista-nwolfe
approved these changes
Mar 27, 2026
Collaborator
|
@venu-nexthop PR conflicts with 202511 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some of the test cases in test_everflow_testbed are failing because there is no
proper verification that the mirror ACL rules are created before traffic verification.
ACL rules are setup once at the beginning so wait_until for ACL rules only once at the beginning of the test.
Summary:
Fixes # (issue)
#22198
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix everflow testbed test cases failures
How did you do it?
Added verification functions before proceeding with the traffic verification
How did you verify/test it?
everflow testbed test cases passing with the fix.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation